From: Mike Rosset <mike.rosset@gmail.com>
To: guix-patches@gnu.org
Cc: guix-devel <guix-devel@gnu.org>, 39229@debbugs.gnu.org
Subject: Re: [bug#39229] qt-build-system: Add QT_QPA_PLATFORM=offscreen?
Date: Wed, 22 Jan 2020 01:20:04 -0800 [thread overview]
Message-ID: <875zh3luez.fsf@gmail.com> (raw)
In-Reply-To: <d4dbba6d-c3ab-484b-a423-833aa36f606c@crazy-compilers.com>
Hartmut Goebel writes:
> Hi Danny,
>
> (forwarding to guix-devel to eventually get more opinions on this)
>
> Am 21.01.20 um 23:43 schrieb Danny Milosavljevic:
>>> + (add-before 'check 'check-setup
>>> + (lambda _
>>> + (setenv "QT_QPA_PLATFORM" "offscreen")
>>> + #t)))))
>> Hmm, would it make sense to do that automatically in qt-build-system ?
>
> I would be fine with this, since I find myself adding this snippet quite
> often when building Qt/KDE applications. But there *might* be cases,
> where tests fail due to this setting. (While I'm not aware of one, I
> could imaging some test checks whether it is actually painting.)
>
> Thus I propose implementing this in some way to easily disable it if
> required: Either
>
> - by adding this a new phase (as in the snippet shown above), so it can
> easily be disabled
>
> - by adding another keyword-argument (proposal: `#:qpa-platform`,
> default: "offscreen", if +f, will not be set.
>
> WDYT?
I think adding this to qt-build-system with the keywords is a good
suggestion.
++
Mike
next prev parent reply other threads:[~2020-01-22 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200121212746.16054-1-h.goebel@crazy-compilers.com>
[not found] ` <20200121212746.16054-7-h.goebel@crazy-compilers.com>
[not found] ` <20200121234321.2e51854b@scratchpost.org>
2020-01-22 8:44 ` qt-build-system: Add QT_QPA_PLATFORM=offscreen? Hartmut Goebel
2020-01-22 9:20 ` Mike Rosset [this message]
2020-01-22 9:24 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zh3luez.fsf@gmail.com \
--to=mike.rosset@gmail.com \
--cc=39229@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=guix-patches@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).