From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: Re: Fix installer restart.
Date: Wed, 12 Feb 2020 11:02:37 +0100
Message-ID: <875zgc5dj6.fsf@gmail.com>
References: <87sgjimtn2.fsf@gmail.com> <87tv3xyw9y.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:52902)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <m.othacehe@gmail.com>) id 1j1oqw-0005Fr-Jc
 for guix-devel@gnu.org; Wed, 12 Feb 2020 05:02:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <m.othacehe@gmail.com>) id 1j1oqv-0008JM-HO
 for guix-devel@gnu.org; Wed, 12 Feb 2020 05:02:42 -0500
In-reply-to: <87tv3xyw9y.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix Devel <guix-devel@gnu.org>


Hey,

> Did you make sure that:
>
>   make check-system TESTS=3Dinstalled-os
>
> still passes?

Yup, still working :)

In the meantime, while testing those patches, I noticed that:

* If you edit the final operating-system configuration with a syntax
error, start the install, then come back to the final page, your changes
are lost. But I'm not sure we can do much about it.

* If you open a TTY4 during "guix init" is running on TTY1, then the
command fails, the cow-store umount will fail because the bash started
in TTY4 will keep the overlay busy. This is a corner-case but it will
happen. Maybe I should check for all processed using the store overlay
and kill them before umounting?

> I=E2=80=99d recommend using =E2=80=98match=E2=80=99 rather than =E2=80=98=
case=E2=80=99, because =E2=80=98case=E2=80=99 silently
> returns *unspecified* when it fails to match the value.

Sure.

> PS: I=E2=80=99m still looking at the installer tests we discussed before =
FOSDEM,
>     but life got in the way so progress is slow!

Hehe, same for all of us :)

Anyway, I'll push soon, thanks for the fast review!

Mathieu