From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aB88Mlv7IV9iUwAA0tVLHw (envelope-from ) for ; Wed, 29 Jul 2020 22:42:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id LfMZLlv7IV8fdgAAB5/wlQ (envelope-from ) for ; Wed, 29 Jul 2020 22:42:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 490D5940223 for ; Wed, 29 Jul 2020 22:42:35 +0000 (UTC) Received: from localhost ([::1]:52786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0umQ-0002V9-7e for larch@yhetil.org; Wed, 29 Jul 2020 18:42:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0umH-0002Ux-IR for guix-devel@gnu.org; Wed, 29 Jul 2020 18:42:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55186) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0umG-00050Q-1R; Wed, 29 Jul 2020 18:42:24 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:52162 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k0umF-0005ln-FG; Wed, 29 Jul 2020 18:42:23 -0400 From: Marius Bakke To: Tanguy Le Carrour , Guix Subject: Re: [PATCH 0/X] gnu: poetry: Fix broken dependency after dependency's version update. In-Reply-To: <20200728154816.zcuysdktcu3me3nv@rafflesia> References: <20200728154816.zcuysdktcu3me3nv@rafflesia> Date: Thu, 30 Jul 2020 00:42:02 +0200 Message-ID: <875za6q6yt.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: PDoEXFS0eoxT --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tanguy Le Carrour writes: > Hi Guix! > > Few days ago, I submitted a patch to update `python-tomlkit`. It was push= ed > to master and, after I upgraded my packages today, I realised that `poetr= y` > (and possibly other python packages) was broken! > > The "problem" is that Poetry depends on `tomlkit =3D "^0.5.11"`. This > translates to `>=3D0.5.11,<0.6.0`. And I updated `python-tomlkit` to=E2= =80=A6 0.6.0! > > In SemVer [1], minor releases are supposed to "add functionality > in a backwards compatible manner", so this "<0.6.0" seems, IMHO, wrong. > But that's not the point=E2=80=A6 > > [1]: https://semver.org/ > > Now, I have to fix Poetry and I have 2 options: > - modify poetry `setup.py` and substitute `>=3D0.5.11,<0.7.0` to `>=3D0.5= .11,<0.6.0`; > - add a new `python-tomlkit-0.5` and use it in the propagated inputs. > > Any suggestion on the one I should implement? I haven't looked into it, but if the tomlkit API really is compatible, the first suggestion sounds good to me. It would be good to notify upstream about the unreasonable "pinning" in that case. Otherwise the second suggestion sounds good too. There is plenty of precedence for both solutions in Guix and is really something that needs to be decided on a case-by-case basis. Thanks for finding and following up on the issue! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8h+zoACgkQoqBt8qM6 VPqynAf9G9J0VLxYWKsKBU1oAZx2wCKi3nxNp24WfgZNVduPf+WQqTTF7vbktJGI 4pxHO3PK7NhgiG/EQb+knHf/N68rVGteigZ2ftODJ/ypKqAtA0BK7o0s77Is5wnx ST/LpGPQfaR6S6rSe4YpfiudbFZo3BD8p+Z707dgE+8/9iDIlOJoKXQN3tF51igz YrKlNIyx2pQr4N7OB6r5hrlBHfjkqYuHWyuLyJPjdS7e8++dYz0xMV4BEdOF2qbP Jplml3yQnzPjdvh1k59kqi0tmbpXdU5sDlpSxpgQu/ZXyA54h9c6RrAOhnRjugUv 8A+tQZBW+HPgf5I1DYKNZ07Qn7sVMA== =841t -----END PGP SIGNATURE----- --=-=-=--