unofficial mirror of guix-devel@gnu.org 
 help / color / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Tanguy Le Carrour <tanguy@bioneland.org>, Guix <guix-devel@gnu.org>
Subject: Re: [PATCH 0/X] gnu: poetry: Fix broken dependency after dependency's version update.
Date: Thu, 30 Jul 2020 00:42:02 +0200
Message-ID: <875za6q6yt.fsf@gnu.org> (raw)
In-Reply-To: <20200728154816.zcuysdktcu3me3nv@rafflesia>

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

Tanguy Le Carrour <tanguy@bioneland.org> writes:

> Hi Guix!
>
> Few days ago, I submitted a patch to update `python-tomlkit`. It was pushed
> to master and, after I upgraded my packages today, I realised that `poetry`
> (and possibly other python packages) was broken!
>
> The "problem" is that Poetry depends on `tomlkit = "^0.5.11"`. This
> translates to `>=0.5.11,<0.6.0`. And I updated `python-tomlkit` to… 0.6.0!
>
> In SemVer [1], minor releases are supposed to "add functionality
> in a backwards compatible manner", so this "<0.6.0" seems, IMHO, wrong.
> But that's not the point…
>
> [1]: https://semver.org/
>
> Now, I have to fix Poetry and I have 2 options:
> - modify poetry `setup.py` and substitute `>=0.5.11,<0.7.0` to `>=0.5.11,<0.6.0`;
> - add a new `python-tomlkit-0.5` and use it in the propagated inputs.
>
> Any suggestion on the one I should implement?

I haven't looked into it, but if the tomlkit API really is compatible,
the first suggestion sounds good to me.  It would be good to notify
upstream about the unreasonable "pinning" in that case.

Otherwise the second suggestion sounds good too.  There is plenty of
precedence for both solutions in Guix and is really something that needs
to be decided on a case-by-case basis.

Thanks for finding and following up on the issue!  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 15:48 Tanguy Le Carrour
2020-07-29 22:42 ` Marius Bakke [this message]
2020-07-30 13:18   ` Tanguy Le Carrour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875za6q6yt.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=tanguy@bioneland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of guix-devel@gnu.org 

Archives are clonable:
	git clone --mirror https://yhetil.org/guix-devel/0 guix-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-devel guix-devel/ https://yhetil.org/guix-devel \
		guix-devel@gnu.org
	public-inbox-index guix-devel

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.devel
	nntp://news.gmane.io/gmane.comp.gnu.guix.devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git