unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: guix-devel@gnu.org
Subject: Re: [website]: Fix rendering of entities.
Date: Sun, 13 Sep 2020 23:52:52 +0200	[thread overview]
Message-ID: <875z8hz6mj.fsf@elephly.net> (raw)
In-Reply-To: <87v9giyplc.fsf@elephly.net>


Ricardo Wurmus <rekado@elephly.net> writes:

> pelzflorian (Florian Pelz) <pelzflorian@pelzflorian.de> writes:
>
>> On Wed, Sep 09, 2020 at 11:35:06PM +0200, Ricardo Wurmus wrote:
>>> Hi Guix,
>>> 
>>> this page looks wrong: https://guix.gnu.org/packages/mpc-1.1.0/
>>> 
>>> The non-breaking space is rendered as “GNU<*ENTITY*>nbspMPC”.  The
>>> attached patch processes the SHTML to remove *ENTITY* nodes, replacing
>>> the “nbsp” entity with an actual non-breaking space; other entities are
>>> silently converted to a single space.
>>> […]
>>> +                              (match entity
>>> +                                ("nbsp" (string #\xa0))
>>> +                                (_ " "))))
>>
>> Nice find.  LGTM as far as I can tell, except it would be nice if the ... / … in
>> <http://guix.gnu.org/de/packages/guile-hashing-1.2.0/> were not rendered as
>> a space.
>
> I will add another case for “hellip”.
>
> I could also convert all descriptions and extract all *ENTITY* tags to
> see what entities there are to be be dealt with.

I only saw “hellip” and no other entities, so I added an extra case for
“hellip” and pushed the change.

Thanks for your comments!

-- 
Ricardo


      reply	other threads:[~2020-09-13 21:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 21:35 [website]: Fix rendering of entities Ricardo Wurmus
2020-09-12 22:06 ` pelzflorian (Florian Pelz)
2020-09-13  9:48   ` Ricardo Wurmus
2020-09-13 21:52     ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z8hz6mj.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).