From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YOxHAvj2w19CYgAA0tVLHw (envelope-from ) for ; Sun, 29 Nov 2020 19:31:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iH22Off2w19rZwAAB5/wlQ (envelope-from ) for ; Sun, 29 Nov 2020 19:31:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 899119404C7 for ; Sun, 29 Nov 2020 19:31:03 +0000 (UTC) Received: from localhost ([::1]:58326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjSPU-0006fV-VL for larch@yhetil.org; Sun, 29 Nov 2020 14:31:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjSOi-0006fC-8i for guix-devel@gnu.org; Sun, 29 Nov 2020 14:30:12 -0500 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:46413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjSOg-0002KV-Jr; Sun, 29 Nov 2020 14:30:11 -0500 Received: by mail-qv1-xf30.google.com with SMTP id p12so4634487qvj.13; Sun, 29 Nov 2020 11:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=0zazEsei8zuOzp/oYEhULBqgIn2NhkfFxzKH8nIEaFs=; b=pneA+JK/mslANijOvjYCL0wYVxaboQvU5j807Y7SwxXrryBsErIW/cXnLuJbogIakc sopl1tumzxbMSkxLfCv4jGnQlw9BhOS9FYiuKYfZMtghMFcdAiHeKvD/n++l823LYJsG bHFHf60WyDUuw5U5xRQhGWLlcHnxpU/gIdCFRSD435y6oVaOjWw5aDvqo1ldxIKp5Efh vdqY+L2fQjHJiAwTnp2OGXRp8wDTpu1U4WGKs74Pl0IqIeUNB58/r47kUcGjfwWc0V76 5Y2TqFrd/tRv/2/F8WE3dZqCcOWtwZAPbQai+ZxKhnEjFxCYOrUSK6X+XCpfR4FdyRsX 462w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=0zazEsei8zuOzp/oYEhULBqgIn2NhkfFxzKH8nIEaFs=; b=dCcYh8jlPTQXV89ZTTyrwCbpQcWX5gHw1smTlaIRBAy+5u3l/bj7dAQqBHhNv2sEpf hmorcPzyCbNgKM+UNRLZJtf7aWkfs37re+fRFDyXFF4a5jghk8E182oGd4GTPLnmcPgY TjXfctrbKYPD609gYuMmMvfN6oatgSZt0EnP4NWo8/Mxis/qbLbmH3RI7v2987iG38ck 561GGQnQ+/gmt/OdHYvAjw1T+W1tCxk17xRW8aqkpusdQVSEfQmOGMopTFIGm2wZRBGo UbK0Jfo3mUGMm1hLzYxpMjLPCWh469OjdncVvvYgbhHw1+2lIk5kKltlHhc2gUJuKy+0 okIA== X-Gm-Message-State: AOAM531k6lNae+ys2090nIRAfiPgTVYTg5qXKbJ4Lzie+DDN8V5LFHF9 DrQeMeGEzzqgSAp9f57ye818QyNMObKqJg== X-Google-Smtp-Source: ABdhPJxJd6cFgrRFo5uJNaiUlMcufWeHDfJ0CGIrZvKAI2mgisiamOiJOvDTZoje10I5tQUzLGBkUQ== X-Received: by 2002:ad4:46ac:: with SMTP id br12mr18639241qvb.18.1606678208718; Sun, 29 Nov 2020 11:30:08 -0800 (PST) Received: from hurd (dsl-150-82.b2b2c.ca. [66.158.150.82]) by smtp.gmail.com with ESMTPSA id r125sm13309561qke.129.2020.11.29.11.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 11:30:08 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: Phases and snippets no longer returning a Boolean References: <87sg8ycpka.fsf@inria.fr> Date: Sun, 29 Nov 2020 14:30:07 -0500 In-Reply-To: <87sg8ycpka.fsf@inria.fr> ("Ludovic =?utf-8?Q?Court=C3=A8s=22?= =?utf-8?Q?'s?= message of "Wed, 25 Nov 2020 00:17:41 +0100") Message-ID: <875z5oneps.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f30; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.98 X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=pneA+JK/; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-TUID: hF9KPr0jS9ob Hey, Ludovic Court=C3=A8s writes: > Hello Guix! > > As a followup to our recent discussion=C2=B9, I pushed the following comm= its > to =E2=80=98core-updates=E2=80=99: > > 16111ad11c gnu: gcc: Phases no longer return a Boolean. > 3504e39a5d gnu: base, gcc: Removing trailing #t from snippets. > 325d00e619 packages: Ignore return value of origin snippets. > 4cebe82fa6 build-system/texlive: Phases no longer return a Boolean. > 49eadd270c build-system/minify: Phases no longer return a Boolean. > 112982526f gnu: base, commencement: Remove trailing #t from build phase= s. > 04baa011e9 build-system/gnu: Ignore the result of phase procedures. > > With these changes, the return value of origin snippets and build phases > is now ignored. It had been deprecated, with a warning emitted at build > time, since March 2018 (notably commit > daac9c77b9ed25a3c0edf843fdfe5e209ebef58f). The introduction of =E2=80=98= invoke=E2=80=99 > (commit 3f65c190d23296e7e718c3deff413e8beb61d8ba), which would raise an > error when a program exits with non-zero, was also an enabler. Because > of that I=E2=80=99m quite confident that breakage is unlikely, but we=E2= =80=99ll keep an > eye on it. > > I only removed trailing #t in a couple of files unlikely to result in > merge conflicts down the road, as Marius rightfully suggested on IRC. > > That=E2=80=99s it! Thoughts? Comments? Not much to say, other than: awesome! It'll be difficult to undo the habit of returning #t in phases ;-). Thanks! Maxim