From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gL0zL43agWAVPQEAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 22:20:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MB3dKo3agWCheQAAB5/wlQ (envelope-from ) for ; Thu, 22 Apr 2021 20:20:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74D1C2140C for ; Thu, 22 Apr 2021 22:20:29 +0200 (CEST) Received: from localhost ([::1]:60626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZfoK-0005YT-Li for larch@yhetil.org; Thu, 22 Apr 2021 16:20:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZfcS-0005xS-Ft for guix-devel@gnu.org; Thu, 22 Apr 2021 16:08:12 -0400 Received: from mira.cbaines.net ([212.71.252.8]:54074) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZfcQ-0003mg-Lc for guix-devel@gnu.org; Thu, 22 Apr 2021 16:08:12 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id 47A9127BC7C; Thu, 22 Apr 2021 21:08:09 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ee53ce47; Thu, 22 Apr 2021 20:08:09 +0000 (UTC) References: <20210421152914.461bbdbb@lubrito> <87bla6iwli.fsf@cbaines.net> <20210422170040.37941083@lubrito> User-agent: mu4e 1.4.15; emacs 27.1 From: Christopher Baines To: Luciana Lima Brito Subject: Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons. In-reply-to: <20210422170040.37941083@lubrito> Date: Thu, 22 Apr 2021 21:08:08 +0100 Message-ID: <875z0ehyl3.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619122829; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=h9MrwHRX5ICWnVZc2nkutXKaj3CxvzUMK4jkx9oRgiU=; b=fhbKVPRlyZ2Y3tFWA46c25DeGCjmkk6Pj6p7UjeeAQB3gW9bSWdn/X/XjlHSbvADseOhoQ wuVIY5qP1Xuox0Jj3XM3lNIFhlS2P1B7yjTYmA9juo4keOsnrRRJo5+rv2c1X9jA8pzj7r 6GLnY9/3WdsrCC38NjcdHdUdxQPGDPO/s+Hq7sHafXf5JP8DasxPXmk8SBJBxygE7Ngyzc V+ZlYdXQdTDs7OQd4i0I6SH00KcGkQNblBHgBp0kuy376/kjfD6mY+LCvPQVQA5PFdodzo Us1WuhfShbOveymjOIi7Nv+pl1IBdZZn8KZY59F8qQrmRd8WQ1Wl1M41RV7vDQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619122829; a=rsa-sha256; cv=none; b=Fobk8Hpn4hmLUDXm3hF74QSlC+yO5hDstGDXKzM1e0J6Q4HASGw5qgIiNMpK5q3qZ2J7ri M0pnl7Hu/2smzq0MY0G52gyqcp0M7wgCN8t3dxShVfFJFRl1afeRwlzCvgPrsLG4N0HFUp p8OXslt5EeZhqM3yk/Ebe+JHoPaEm6SppLOBiMlVW2z2uNqj5D2+qrqUA4HyJ/jDTPt2D7 ENtPctGqxrgU2JF/K3AAeFhpn36Q2AuzXwCkp5tyCuH18QzrkNVQJXSAmBVLLmkdsQuqTr 31Bjfxq9jI6tuNyMfl5DO/f4x+a5VWttCUmgk2HeDrLp6ZHvWdis79K2AhDGnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -4.55 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 74D1C2140C X-Spam-Score: -4.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6L3oyTTW4U06 --=-=-= Content-Type: text/plain Luciana Lima Brito writes: > Hi, > >> Small intentional changes are better, so I'd start just with looking >> at some of the data coming out of the query. But yes, I think you're >> in the right place. The hard part here is probably to look at how >> those values are used in the JSON and HTML rendering code, and adjust >> that accordingly. > > I made some modifications(moved the tests from controller.scm to > comparison.scm) in order to remove the value "#f" from the outputs > "hash-algorithm" and "hash" when rendering the html, for derivations > that don't have these values set, but doing that now I'm showing them > as empty fields on the json (instead of omitting them entirely). I'm not quite sure what you mean by empty fields in the JSON here? > This simplified a bit the processing on render-compare/derivations, > and I think the html output is also better. For inputs, sources, etc, > there are no processing being done on controller.scm other than the > map. I can't see now what else could be done in this regard. > > An idea I had was to remove the entire map functions from the > controller.scm to comparison.scm, but this would impact the html, so I > would also have to modify the html, because the data format for json and > html are slightly different. I'm not sure if this is what you want. It sounds like you're roughly on the right track, do share what changes you're making and then I can have a look. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmCB16hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XecIw//drCCrRB4VqzAr0WHnu58bOQQf5aUL8hv LsBbxPIcqytf8tY4SYeYWqDAx/D6DPHjhZVKBMsDyxjog34s9AWae8m9m2+nRbBN jGjiNBjixbbh13iDn2UBWxW7Xzxkxhnfy2gukKnFnrwM4IYqLtdKNvvlbv3FbtfY otwE3Sd2cb2PKipDBcJIMFMIFz99+fsRZohhzYnmETcxX891gcMP6Re9YIH2lXYA n1LwDpbO4azJNhqjGq2IkGjCfU4DkzEVPWapc8mduMfYBwYKQJS374izapOFI47N L/krGsZsQnXCKJ6fuOhkL8OzJIBPaL7gvtgpZsZQOTmUlgiPU2g6tXpQw/wU8S2t WeDF+dUCE0VBWz2r7Ffy5FozhiD4VoCE0I+aJZrGxihJBK13j07fJAftIkdziv0k E13OmgGxDBnQsMlQxwOh1aI1Ntkh1TqBSRip0aRnbiUoP5pVzEy7fVO+Gm5kk27f BjMYgCIiZF6wgqz/BSSigR5cyGMJthOJLJKcE8d/+1NuWIpMZr0OAHxNZJTR8gJ9 /ni27j7Ucp2L6+rhzcERi7s5TsJn17Ki3dF7Vb57CMwXVGvW95eku/GhQXTM6Toc CFbWAEPTgluH12Y5KI67oLQCSAQdO2bfSScUoKtVTmr+e1JMSWv/C/Q3Qja+32Ck rUvSqCySAWY= =GW6W -----END PGP SIGNATURE----- --=-=-=--