From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +zwsJbFVCWH9WwAAgWs5BA (envelope-from ) for ; Tue, 03 Aug 2021 16:41:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KHIYILFVCWGHMgAAB5/wlQ (envelope-from ) for ; Tue, 03 Aug 2021 14:41:53 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4385820F7D for ; Tue, 3 Aug 2021 16:41:52 +0200 (CEST) Received: from localhost ([::1]:53866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAvc6-0004DR-TN for larch@yhetil.org; Tue, 03 Aug 2021 10:41:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAvbt-0004BN-4V for guix-devel@gnu.org; Tue, 03 Aug 2021 10:41:37 -0400 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]:44966) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAvbr-00045R-5N for guix-devel@gnu.org; Tue, 03 Aug 2021 10:41:36 -0400 Received: by mail-qt1-x835.google.com with SMTP id g11so14058731qts.11 for ; Tue, 03 Aug 2021 07:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DzZyzAaRWRLoi2UJdXDEsm8uV/WrQ6nogLQXGhn54Gs=; b=AKrbSVDYpn4i/C8hwHEjpcjbxY+a4mte370NhgsFoigSlbI9QPcxwmsToiUPqLjNJW sHehFMHIQDDRXQnx4SFMs/6Yqbc5tR+53AADHQ9KEt6wUQ1E9YcW6e8gMxKqVnnOXyIH 161P6sQFsAzfZTUKEgax8N1j9QsaxgNm5xZQUzgPpyqZsd0bFDlC3BX9gqvZq4JSemYR FXOgj4p73OIYrl7Kknu5U+8GIhTtLdxD6VCesQppMKWnWz0UdWm+FdPAhqHYcCMDjXBg f2gHCm+0UlSReznURhUCnabL4/ysseNGXZ4le3o2k61YkEwtMWaQptkgTStQI6kMcZQB yb9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DzZyzAaRWRLoi2UJdXDEsm8uV/WrQ6nogLQXGhn54Gs=; b=gtQArg+CuPwh1Wisddk/uHv2Hv09x6PQUA3BLcnpn8rC5DQE2w8Ki1vMfEcgOoP35j wCdoawbCiJ8Kb6HQzgYbg1MS4ExrCXklpFi1z3v8/ewIDrMwFsbgoA027D0OHTMJEftp Q/R2ZaMjqgCBrlNxP40zZynI3Ragm7y5CK9KiXusfDr8NQu2+I4Y39iHm+mOw7uQ7n1v fYTcExkONQQAQMxmJf1pKnxztCmCL3OAKd3oqkmTzOeVjsQM7Dbsr7NCkhItQe/byVWE LA93CxT4g2A5SpUN/gknK4FXW3V4tn42JXFI69D87Hep0Ie1tCBV6EssoQzjnQnIKf5+ DeQw== X-Gm-Message-State: AOAM530GNSR4qTE0TBCiMIn2FwhiGKy6oWCrs6iyaQODOfvckM4/ztX8 HpXT87LoavCTCWFGgHGWDeHE5BvaxbDZRSKS X-Google-Smtp-Source: ABdhPJw6Am20WZL5CqGcdGkvObI99Gulf5vtZFnNTHAtwTLSno6hDde3H6KkHm22RVsj/kbs6Le3jA== X-Received: by 2002:a05:622a:183:: with SMTP id s3mr18301744qtw.169.1628001693944; Tue, 03 Aug 2021 07:41:33 -0700 (PDT) Received: from hurd (dsl-10-129-132.b2b2c.ca. [72.10.129.132]) by smtp.gmail.com with ESMTPSA id f2sm6128732qth.11.2021.08.03.07.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Aug 2021 07:41:33 -0700 (PDT) From: Maxim Cournoyer To: Chris Marusich Subject: Re: GNU Guix 1.3.0rc2 available for testing! References: <874kfdvuuu.fsf@gmail.com> <87r1ic5i3t.fsf@gmail.com> <87lf8h70zx.fsf@gmail.com> <87im2vs5cd.fsf@gmail.com> Date: Tue, 03 Aug 2021 10:41:32 -0400 In-Reply-To: <87im2vs5cd.fsf@gmail.com> (Chris Marusich's message of "Thu, 03 Jun 2021 01:46:42 -0700") Message-ID: <875ywm7fqb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::835; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x835.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628001712; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DzZyzAaRWRLoi2UJdXDEsm8uV/WrQ6nogLQXGhn54Gs=; b=pLUZnGjT99EeRxJqb2MYPp5b2m1eTdxe96AGIbktxTqKMUypOvUJyG7W/Gsos8DcVYMFEs ORWiMTf5nwwIWo7huOK1WSp1lBOPFJ7wl+MVi6xQiCxTmfcl8oiNlSSphcPk5CU+o1KvYt KjwS7+Ya9ju8dvA4aakJ+1PTYWKo2mW+ArHZetnyEiQZ4UfyWEv+Lrv1rSQqCSG7XkQBBF Q3rswaxe6B5Rhd9QPcCpvlXNRi9prujzugRrdISnh6qTzrMsqz3/5K3wqTmHdAfMkCe7dB yM2RdbrG/xXAfOULd4fLmvVwpBrMfNlLIzoEaYqUZQIpKO42UJoa8VE5tguziQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628001712; a=rsa-sha256; cv=none; b=T6SxhrcegBQ8wC+YjYUSYttfpGrY9RJaBlNy5N4nk7uRMTYvqKScFiO5j0QZVJWzstTKAQ Fm/nsAThYGr6FhgrhWTjfwEXz5s7WbNXfPPTlJK3V8XG/FUGtLmwidqxpK0lECobHJqJL9 GfEq9liCXbiTIahrUsOykiyrQdbdj+67I+VRYyMmYYjgUEQORGkPqC87f4NkjXKBosFVVA Hy0FrjlgXevHuZxvOuczFZSJ83YiYBCKBnOOFavADPIjxyHH3jDZblYcO44c4I2jDgCXgh 741l9wxM/s/8V+HgieW1V8Yd0nNzcLKd8rggF5gigvNlAHzDCMzgHiMN+wWXYQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=AKrbSVDY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -1.62 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=AKrbSVDY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 4385820F7D X-Spam-Score: -1.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: zW8n3+q850u2 Hello Chris, Chris Marusich writes: > Hi Maxim, > > Maxim Cournoyer writes: > >> Sorry for the delayed answer. > > No worries! I've waited even longer in replying to you now, so we're > even. :-) > >> The go importer depends on a recent version of guile-lib (0.2.7), which >> added a new #:strict argument to the HTML parser. We should probably >> skip the test depending on the already available HAVE_GUILE_LIB Automake >> conditional, like so: >> >> modified Makefile.am >> @@ -457,7 +457,6 @@ SCM_TESTS = \ >> tests/git-authenticate.scm \ >> tests/glob.scm \ >> tests/gnu-maintenance.scm \ >> - tests/go.scm \ >> tests/grafts.scm \ >> tests/graph.scm \ >> tests/gremlin.scm \ >> @@ -505,6 +504,10 @@ SCM_TESTS = \ >> tests/uuid.scm \ >> tests/workers.scm >> >> +if HAVE_GUILE_LIB >> +SCM_TESTS += tests/go.scm >> +endif >> + >> if BUILD_DAEMON_OFFLOAD >> SCM_TESTS += tests/offload.scm >> else >> >> Could you give the above a try? Feel free to commit it if it works as >> expected. > > I tested this, and it works. Thank you! I can now build the release > (with this change) and run the tests (make check) successfully; > tests/go.scm is just omitted from the tests to run. > > By chance, I noticed the following lines below what you added: > > if HAVE_GUILE_LIB > SCM_TESTS += tests/go.scm > endif > > if BUILD_DAEMON_OFFLOAD > SCM_TESTS += tests/offload.scm > else > EXTRA_DIST += tests/offload.scm > endif > > > I guess that if we omit tests/go.scm from SCM_TESTS, it not only means > that the test won't be run, but it also means the test won't get > included in the tarball distribution ("make dist"). Is that right? It > seems undesirable to omit this test from the distribution just because > the machine on which the distribution was built might have lacked the > library necessary to run the test. Someone who builds Guix from the > distribution might actually have that library installed and thus be able > to run the test. To ensure that this test always gets included in the > distribution, perhaps we should also add it to EXTRA_DIST like so: > > diff -u a/Makefile.am b/Makefile.am > --- a/Makefile.am 2021-05-11 11:09:31.000000000 -0700 > +++ b/Makefile.am 2021-06-02 12:55:06.134793001 -0700 > @@ -457,7 +457,6 @@ > tests/git-authenticate.scm \ > tests/glob.scm \ > tests/gnu-maintenance.scm \ > - tests/go.scm \ > tests/grafts.scm \ > tests/graph.scm \ > tests/gremlin.scm \ > @@ -505,6 +504,12 @@ > tests/uuid.scm \ > tests/workers.scm > > +if HAVE_GUILE_LIB > +SCM_TESTS += tests/go.scm > +else > +EXTRA_DIST += tests/go.scm > +endif > + > if BUILD_DAEMON_OFFLOAD > SCM_TESTS += tests/offload.scm > else > > What do you think? Well observed! Makes sense to me. Feel free to push such change if you haven't already. Thank you! Maxim