[core-updates] qtbase 6 ssl tests fail.

[core-updates] qtbase 6 ssl tests fail.

[Ricardo Wurmus]

Hi Guix,

on core-updates qtbase 6.3 fails its test suite.

The tst_QSslKey group of tests has 122 failures that all look like
this:

FAIL!  : tst_QSslKey::passphraseChecks(DES) '!key.isNull()' returned FALSE. ()
   Loc: [/tmp/guix-build-qtbase-6.3.2.drv-0/qtbase-everywhere-src-6.3.2/tests/auto/network/ssl/qsslkey/tst_qsslkey.cpp(626)]

The tst_QSslKey failures are the only tests that fail.

I’m currently working on upgrading linphone-desktop (I’ve upgraded all
its dependencies already, but haven’t pushed them yet) and the current
version needs Qt 6.

Is anyone of you working on Qt 6 on core-updates?

-- 
Ricardo

Re: [core-updates] qtbase 6 ssl tests fail.

[Josselin Poiret]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

Hi Ricardo,

Ricardo Wurmus <rekado@elephly.net> writes:

> Hi Guix,
>
> on core-updates qtbase 6.3 fails its test suite.
>
> The tst_QSslKey group of tests has 122 failures that all look like
> this:
>
> FAIL!  : tst_QSslKey::passphraseChecks(DES) '!key.isNull()' returned FALSE. ()
>    Loc: [/tmp/guix-build-qtbase-6.3.2.drv-0/qtbase-everywhere-src-6.3.2/tests/auto/network/ssl/qsslkey/tst_qsslkey.cpp(626)]
>
> The tst_QSslKey failures are the only tests that fail.
>
> I’m currently working on upgrading linphone-desktop (I’ve upgraded all
> its dependencies already, but haven’t pushed them yet) and the current
> version needs Qt 6.
>
> Is anyone of you working on Qt 6 on core-updates?

I also got bitten by this when building my own package manifest (for
qpwgraph).  The fact that it needs quite a lot of time was quite
discouraging so I just abandoned the idea of doing it myself.  I might
revisit it by just building in a `guix shell -C` instead.

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

Re: [core-updates] qtbase 6 ssl tests fail.

[Josselin Poiret]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

Hi again Ricardo,

I just saw that you disabled these tests with
03580b5f1d997df066a5119cf0a242f827354ba8, by saying that not all key
types are supported by our build of OpenSSL.  Wouldn't this be an issue
on our part, especially if Qt expects these to be available?

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

Re: [core-updates] qtbase 6 ssl tests fail.

[Josselin Poiret]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

Hi Ricardo,

I see you've fixed this by disabling the qssl tests, however I think
this is a shortcoming on our part.  Qt 6.4 has a fix for this, so I
wanted to upgrade our Qt to 6.5.0.  Upstream only supports the Ninja
CMake generator, so I also adapted the package definition to it.  One
issue is that one file takes 4G of RAM to build on my computer, and so
gets terminated on a parallel build.  What would be the usual policy
with such a problem?

Disabling parallel builds for Qt 6 would massively slow the whole build,
so I'm not sure this is a solution either.

Here's the patch I have for now.

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

[PATCH] WIP upgrade qt 6 to 6.5.0

[Josselin Poiret]

---
 gnu/packages/qt.scm | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index acf2d70736..46fbdb2368 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -68,6 +68,7 @@ (define-module (gnu packages qt)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages cpp)
+  #:use-module (gnu packages crypto)
   #:use-module (gnu packages cups)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages databases)
@@ -593,29 +594,28 @@ (define-public qtbase-5
 (define-public qtbase
   (package/inherit qtbase-5
     (name "qtbase")
-    (version "6.3.2")
+    (version "6.5.0")
     (source (origin
               (inherit (package-source qtbase-5))
               (uri (qt-urls name version))
               (sha256
                (base32
-                "19m9r8sf9mvyrwipn44if3nhding4ljys2mwf04b7dkhz16vlabr"))
+                "1vzmxak112llvnx9rdgss99i9bc88rzsaxn59wdyqr5y9xxsmqgx"))
               (modules '((guix build utils)))
               (snippet
                ;; corelib uses bundled harfbuzz, md4, md5, sha3
                '(with-directory-excursion "src/3rdparty"
                   (for-each delete-file-recursively
-                            ;; The bundled pcre2 copy is kept, as its headers
-                            ;; are required by some internal bootstrap target
-                            ;; used for the tools.
-                            (list "double-conversion" "freetype" "harfbuzz-ng"
-                                  "libpng" "libjpeg" "sqlite" "xcb" "zlib"))))))
+                            (list "blake2" "double-conversion" "freetype"
+                                  "harfbuzz-ng" "libpng" "libjpeg" "pcre2"
+                                  "sqlite" "xcb" "zlib"))))))
     (build-system cmake-build-system)
     (arguments
      (substitute-keyword-arguments (package-arguments qtbase-5)
        ((#:configure-flags _ ''())
         `(let ((out (assoc-ref %outputs "out")))
-           (list "-DQT_BUILD_TESTS=ON"
+           (list "-GNinja"
+                 "-DQT_BUILD_TESTS=ON"
                  (string-append "-DINSTALL_ARCHDATADIR=" out "/lib/qt6")
                  (string-append "-DINSTALL_DATADIR=" out "/share/qt6")
                  (string-append "-DINSTALL_DOCDIR=" out "/share/doc/qt6")
@@ -759,9 +759,6 @@ (define-public qtbase
                       ;; The 'tst_qfilesystemwatcher' installs a watcher on
                       ;; '/home', which doesn't exist in the build container.
                       "tst_qfilesystemwatcher"
-                      ;; Not all of the tested formats are supported by our
-                      ;; build of openssl; 871 passed, 122 failed.
-                      "tst_qsslkey"
                       ;; The 'mockplugins' test fail following error: "Unknown
                       ;; platform linux-g++", and the other plugin tests
                       ;; depend on it.
@@ -848,14 +845,21 @@ (define-public qtbase
                            '("device_config.prf" "moc.prf" "qt_build_config.prf"
                              "qt_config.prf"))
                     (("\\$\\$\\[QT_HOST_DATA/get\\]") archdata)
-                    (("\\$\\$\\[QT_HOST_DATA/src\\]") archdata)))))))))
+                    (("\\$\\$\\[QT_HOST_DATA/src\\]") archdata)))))
+            (replace 'build
+              (lambda* _
+                (invoke "cmake" "--build" ".")))
+            (replace 'install
+              (lambda* _
+                (invoke "cmake" "--install" ".")))))))
     (native-inputs
      (modify-inputs (package-native-inputs qtbase-5)
-       (prepend wayland-protocols
+       (prepend ninja
+                wayland-protocols
                 xvfb-run)))
     (inputs
      (modify-inputs (package-inputs qtbase-5)
-       (prepend bash-minimal coreutils-minimal libxcb md4c)
+       (prepend bash-minimal coreutils-minimal libb2 libxcb md4c)
        (replace "postgresql" postgresql))) ;use latest postgresql
     (native-search-paths
      (list (search-path-specification

base-commit: ac8b2a0469a4884353ac5c0f0854012da0b04fda
-- 
2.39.2