From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Philip McGrath <philip@philipmcgrath.com>
Cc: guix-devel@gnu.org, ludo@gnu.org
Subject: Re: tracking /etc/profile.d/*guix.sh in downstream distributions
Date: Wed, 24 May 2023 20:45:07 -0400 [thread overview]
Message-ID: <875y8hgrxo.fsf@gmail.com> (raw)
In-Reply-To: <842534819.0ifERbkFSE@bastet> (Philip McGrath's message of "Fri, 19 May 2023 23:37:06 -0400")
Hi,
Philip McGrath <philip@philipmcgrath.com> writes:
> On Friday, May 19, 2023 6:10:53 PM EDT Vagrant Cascadian wrote:
>> Philip McGrath recently pointed out that the /etc/profile.d/guix.sh
>> snippet had not been updating in the Guix packaging for Debian:
>>
>> https://bugs.debian.org/1036304
>>
>> (and as bonus complication, was also renamed to zzz-guix.sh)
>>
>> The reason I never noticed before is because it is actually a manual
>> process, with this script embedded in the sys_create_init_profile()
>> function of etc/guix-install.sh ... and thus easy to miss when updating
>> packaging.
>>
>> What would be the impact of separating the /etc/profile.d/zzz-guix.sh
>> into a separate file upstream? Would guix-install.sh need to be adjusted
>> to guix-install.sh.in so as to embed the contents of this file?
>>
>
> I think this would also make it easier for Guix contributors to edit the file.
> When I sent a patch for it, Ludo’ and I both got to learn about the obscure
> feature of Bash here documents it uses: https://issues.guix.gnu.org/56050#11
> Ludo’s informal poll results suggest that others would be confused, too:
> https://toot.aquilenet.fr/@civodul/108590952454715930
>
>> Alternately, maybe guix-install.sh could be updated to optionally output
>> or generate the zzz-guix.sh file either by passing commandline arguments
>> or some other conditional mechanism?
One problem I see with extracting that from the script (and relying on
the build system to stitch the final script together), is that we then
can't simply link to the repo as we currently do for
https://guix.gnu.org/install.sh or https://guix-install.sh (they simply
point to
https://git.savannah.gnu.org/cgit/guix.git/plain/etc/guix-install.sh).
--
Thanks,
Maxim
prev parent reply other threads:[~2023-05-25 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 22:10 tracking /etc/profile.d/*guix.sh in downstream distributions Vagrant Cascadian
2023-05-20 3:37 ` Philip McGrath
2023-05-25 0:45 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y8hgrxo.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=philip@philipmcgrath.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).