From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id cI8ZN0j8dWVX4wAA9RJhRA:P1 (envelope-from ) for ; Sun, 10 Dec 2023 18:58:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cI8ZN0j8dWVX4wAA9RJhRA (envelope-from ) for ; Sun, 10 Dec 2023 18:58:32 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=eg55fd28; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702231112; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=mGqDe4mB79nYEzOnPqhgd2xEA1IALDSwIbknJNMtXu8=; b=psLUdN0FGsHwOWXY5N1bolnv16J2WmbCthoiCLSgtRNo7Vygn6QkceFtSNAyXJ12D+eyeL 8tbwRTwgZ9BCPDbmXAZc43Hap2FuQlx2EXTOO0SLkzbzuMFEGyDGghkq/3JgB9FnfV7+Zt 9Wg4tmnVLZq9FA90ODroqUR8DsnsLNoCLzKP/raOezOYO5H045FTZ9hjLIS3HUZucxRBhs GVRgDiLWZGfFWI0jYKYQVh1pMCsJzxKH0ma5N6caFHwRtYlTiJp82t65B2fR2Rip45OvFy rfYGvZE+xiZPBg1zfOKGNuyWrRP1qKH/n7/jlFjKZLKd/Gi54WoaS2ath3EQNg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=eg55fd28; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1702231112; a=rsa-sha256; cv=pass; b=kxRp3TWvxKc2lnAqvmllkoEc1T763Zt8lmh5mIWVjBkIB0AIqWgy/hUxrRmB//fctQOP6n HNUhimMCBkWg26P82Bu+v7ASvpaTgiumZh6nN9lh4GhXgOsHA7htGHKAD0RSeIMLYPeeAI jPWPTr6sK9iEYxYpvGPUJT9SGP1f2SqN6tyOSEGLQ8GlhfdDeDvfaxgLR9tZPCmQF94Ggq d4TmypPhqYdUA+gBmRo/SN+upJsApcSvvczs+d75dABNTYP5TwwCweP090QwORhojinkFX e3S+rIr7CJE6tA6UAMeyxtvjjyxZhPyPukYKsdLc8bqb/3y8ojrTkMU2caJ9YQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C03595FC13 for ; Sun, 10 Dec 2023 18:58:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCO3v-0007HQ-5M; Sun, 10 Dec 2023 12:57:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCO3r-0007HC-IM for guix-devel@gnu.org; Sun, 10 Dec 2023 12:57:51 -0500 Received: from sender4-of-o50.zoho.com ([136.143.188.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCO3p-0007pr-Rw for guix-devel@gnu.org; Sun, 10 Dec 2023 12:57:51 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1702231066; cv=none; d=zohomail.com; s=zohoarc; b=ctMoBn3JRRrY36RCYHefleAf3U19pUEhXRscS5kCT6yqgKhfjv++2ARomM4M3ikV0KlVESX03bf0gf51iPxGsJxb9r3B3J+blbkG91sHIWhVzg8wCptZtpToIkNKMNwiGNE8UwePnMngAqI/hCIJGnXLCWpKWF+UXA8PxYROv70= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702231066; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=mGqDe4mB79nYEzOnPqhgd2xEA1IALDSwIbknJNMtXu8=; b=kpgzSXuh/qejfFmfTQrTJ9mwH6aDfxdg8RiNLu39Tik4eZIrY39+IJi0fn384xs/ROeqqx5Wd8DjAOcooMVgI6y8G1P5wjsPS5foJg/4kl6+xceSUcFN+NDRnaiFpObnnf+S7c2SPoFM1iqv5o8dbkWI+7ypIgN422yEZYrWmvk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1702231066; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=mGqDe4mB79nYEzOnPqhgd2xEA1IALDSwIbknJNMtXu8=; b=eg55fd283AZ2H4eBeITlUBY8VztMJzfZDVGU7z4xDg3DzTH5O1pe67juhkH0GEmf +KHkYQqVh2nZu1JDzkQDga56pnoVPoHMMjgq9fyR42EJFHz+HBstOX4aH0W5kSo86lG VhdGHZqyMwSV+pmdupk5n/h048udC30k+7VSLTeY= Received: from localhost (186-110-142-46.pool.kielnet.net [46.142.110.186]) by mx.zohomail.com with SMTPS id 1702231064276807.553976587486; Sun, 10 Dec 2023 09:57:44 -0800 (PST) References: <6bcc9412f092c20fbd7f8326dbf91e90cef0eed1.camel@gmail.com> User-agent: mu4e 1.10.8; emacs 29.1 From: Ricardo Wurmus To: Attila Lendvai Cc: Saku Laesvuori , Liliana Marie Prikler , guix-devel@gnu.org Subject: Re: Should commits rather be buildable or small Date: Sun, 10 Dec 2023 18:50:51 +0100 In-reply-to: Message-ID: <875y16c54b.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.50; envelope-from=rekado@elephly.net; helo=sender4-of-o50.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.57 X-Spam-Score: -3.57 X-Migadu-Queue-Id: C03595FC13 X-Migadu-Scanner: mx10.migadu.com X-TUID: Jx3fouEN4dLC Attila Lendvai writes: >> I guess "required" here means that in some cases Guix's policy is to >> prefer small commits over buildable commits (with the previous >> definition). I at least don't see any technical reasons why it would be >> required. The question then becomes whether that policy applies in this >> case. > > > FWIW, this commit policy has always bothered me as a newcomer to > Guix. pretty much everywhere else it's a major offence against your > colleagues to commit something that breaks the build in any way. In the last few months I=E2=80=99ve repeatedly seen assertions in a similar style as this one. They always genuinely surprise me, and it=E2=80=99s pro= bably not just because I=E2=80=99m oblivious and out of touch. Also in Guix it is not okay to commit intermediate things that break stuff. Commits should, however, also tell a reviewable story and not be a big blob of thousands of lines of non-trivial changes. (The one exception has always been fixes of repeated typos, but this is not what this discussion is about.) For what it=E2=80=99s worth: when I do bulk R upgrades I generally have one commit per package upgrade, because it=E2=80=99s easy to review in a git lo= g in the future and easy to revert individual changes with fine grain access. Of course I group upgrades that depend on one another (e.g. r-arrow together with apache-arrow and the inheriting python-arrow). --=20 Ricardo