From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id gNbBKBbhf2csNAAAqHPOHw:P1 (envelope-from ) for ; Thu, 09 Jan 2025 14:45:42 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id gNbBKBbhf2csNAAAqHPOHw (envelope-from ) for ; Thu, 09 Jan 2025 15:45:42 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=nanein.fr header.s=mail header.b=u3PbmPU+; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=reject) header.from=nanein.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1736433942; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=buu/LItP2lXWebySbjsLX0t/Ydtox35sUnv6ztWRUq4=; b=SUqmyOEfoj434Amzl3FB5DmyN/ULvM1Xh/1PbwABRCX/dVYIATTpibKeeAbrSQyCs5a1Li wtFr2jPL/b0O2XQIcBqHNotIEXryNNMPLbtVFu9wzN8PNa4Bb8PC4/q+mtuB3oQ0QW5Fje 3oDxo+rNqz9DTR0nyCMNWERy/rGSOH6bVb3BUZAT//YWNVHpf3SM9I5SZ9m3M+tV+7t66E aPAWoJar92IfhEO6VH/ekGb3swwjSRazDxhzGCk9JVQZnPFSILtJx8nsKRO6Z+ntcGoUyM ZiqM7aqSC5T4sCQF2sXcS+uj3yCOTSZ/RmgQUovcFU25kufcyCE5OVxErDQy0w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=nanein.fr header.s=mail header.b=u3PbmPU+; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=reject) header.from=nanein.fr ARC-Seal: i=1; s=key1; d=yhetil.org; t=1736433942; a=rsa-sha256; cv=none; b=Y2ocfiem1YesyrhZRfPwTf2W5xWStEVhZSnThtsINQTZmXZOoGoD3FWswMKLpX/MmJrnSK fJWQJkp3c2EK/HVCYtOiYdGprM0vHmLYOJZrce90nuiaZXFiupzqUCsq+EupLE4qBk6Zt4 8gxIhDpYO8D0OpDougXNsvmFSUjBpsy67Ykfq/hXQAZ8YeRuyHutq9eMjh+S/DPB9/4pNQ UCwWSYRTc2RZrmFdf7mQOP/DHbXLRjqcstvbtcTAhg4+6lDsiamz1Xd4xkS2bad+PW+pKF A+5xvrNOsTZLA/bULsBvcoRzjdo5SiEMQF2eOc8/TB++SgZtwkLFKvEAH0vX5w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A7394D2A for ; Thu, 09 Jan 2025 15:45:42 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVtmd-0002rt-3X; Thu, 09 Jan 2025 09:45:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVtmR-0002m3-M7 for guix-devel@gnu.org; Thu, 09 Jan 2025 09:45:04 -0500 Received: from mx1.nanein.fr ([2a0c:700:12:50:1::103] helo=nanein.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVtmO-0007g6-2m; Thu, 09 Jan 2025 09:45:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nanein.fr; s=mail; t=1736433883; bh=P3fcGZNuIlX5sqBoC/5o0/aQAwDc/hkQgHCH7TjGqFY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=u3PbmPU+YZqb2tJQPcktLhwmX7sRyO26aIA2d1o1duTCgOasHhhPC+5skKkbT8FM5 9t63OFj08KMihM0JKkGjjGhVFvuHv7eX4d+W/SjTpa5IK2FEZzih9wJSjFzfnzm7Wg 2f1Ho/XIsUzN+XMVgvuxvv74v59pv0Q11SM3U9co8eslYoLEt7V1O9xKpOBjJdSAmk FwryMha0B/NO6fx8+KTBUekT6rhnKO2naIUh+cVABw1LURy+XxN23/g4nSaoSVQwdR Tq5wlplnNCzc9bxjDjjJlt+PDiQwv3+rspa4FdwwSudJ3cxJLAP72dohOQmt42AGkw PXmsnEcHYQYkGfooV+/tKCnFKUmrOrJJGpJccOJ7zaq2d57iraAGNExnwmI1szl200 tUE2Pps/haWRQWq7nwB82PrCHpJ4dQdFqnXV008QJQNj7LRB1Am/WQ7lNpnh+iL8oG VjNGCpR1UEesn5WGSC6VdWSCG5IU+6lGeDtTXOo/dvmeDHByc3PO9qo6qZllGpjwgU 5UVWHehTllC3lG5yRD2CXWFqA0dEr73kz6wb1elYZNWdqU/IDCCwdCvsOcPWDEsZcA IAsiLQKw05Mrk9ndvw+LomjJfcuh+Wv55C1actT0IG5mZgMaxwX9kz5vOvkncmCb3j SaJntCKmlyshPj+CHQkb2szI= Received: from cochea (eduroam09.au.dk [185.45.22.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by nanein.fr (Postfix) with ESMTPSA id 194791401EC; Thu, 9 Jan 2025 15:44:43 +0100 (CET) From: Arnaud Daby-Seesaram To: 45mg <45mg.writes@gmail.com> Cc: 75145@debbugs.gnu.org, guix-devel@gnu.org, Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= , Maxim Cournoyer Subject: Re: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field. In-Reply-To: (45mg.writes@gmail.com's message of "Thu, 9 Jan 2025 12:24:30 +0000") References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@gmail.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Thu, 09 Jan 2025 15:44:27 +0100 Message-ID: <875xmo11ys.fsf@nanein.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a0c:700:12:50:1::103; envelope-from=ds-ac@nanein.fr; helo=nanein.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 4A7394D2A X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.26 X-Spam-Score: -3.26 X-TUID: 36OGT8yNxv/F --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Thank you for your patch. 45mg <45mg.writes@gmail.com> writes: > As the first revision of this patch failed to get any attention in two we= eks, > I'm CC'ing guix-devel on this one, hoping it'll get reviewed this time. L= et me > know if I should have done anything differently; I'm still relatively new= to > contributing. I am also new to contributing, so the following may not be fully accurate. I think that you did everything right. Unfortunately, some patches "fall through the cracks". I have seen some people replying to issues=C2=A0[0], so that emails would show up in people' mailboxes (similar to what you did) and restart the discussion. I think that it is also possible to suggest simple patches for patch review events [1]. I do not know if proposing one's own patches is frowned upon or not, but I would not expect it to be as long as there is no abuse. [0] Random example: https://issues.guix.gnu.org/64620#21 [1] Wiki page for last year: https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024 > This patch allows users to specify configuration files for NetworkManager. > While perhaps it would be more Guix-y to instead have a field in > `network-manager-configuration` for every configuration option, this woul= d be > a monumental undertaking (look at the number of options listed in > NetworkManager.conf(5)!). At any rate, I think any means of configuring > NetworkManager is better than none. I agree that an escape hatch enabling to configure NetworkManager would be nice indeed. > The difference from the first revision is that instead of specifying a si= ngle > directory (file-like object) containing the configuration files (which was > then symlinked to /etc/NetworkManager/conf.d), you now specify an alist > mapping file names to file-like objects, like with `etc-service-type`; and > those are then added to /etc/NetworkManager/conf.d. The rationale behind = this > change is that it doesn't rule out putting our own stuff in > /etc/NetworkManager/conf.d. For example, if we wanted a default set of fi= les > in there, we could modify the procedure > `network-manager-configuration-directory` to add the files supplied via t= he > field to our default set; in the first revision, this wouldn't be possibl= e as > the user specifies the entire directory. (I don't know whether we'd ever > actually want to do this, but I thought it best to leave our options open= .) On adding default files in .../conf.d/: ``````````````````````````````````````` Adding a default configuration could one day be interesting. However, I=C2=A0would rather (personal opinion) see the default value in an exported variable %default-networkmanager-files (non-contractual name) if needed. This variable could become the default value of the field. This way, it would be more transparent to users, and would enable them to easily opt-out. Adding their files could be done with the following configuration: =2D-8<---------------cut here---------------start------------->8--- (extra-configuration-files (cons* `("file1" ,(plain-file ...)) ... %default-networkmanager-files)) =2D-8<---------------cut here---------------end--------------->8--- On doing a similar job than `etc-service-type': ``````````````````````````````````````````````` As you said, you are doing something similar to `etc-service-type'. Is there a reason not to extend [2] it directly (e.g.=C2=A0like `greetd-service-type' does in `(gnu services base)')? You could, for example, prepend "NetworkManager/conf.d/" to file names and pass the value to `etc-service-type'. WDYT? [2] more on service extension can be found in (guix)Service Reference: https://guix.gnu.org/manual/devel/en/html_node/Service-Reference.html Final thought: `````````````` Would it make sense to allow the NetworkManager service to be extended? (E.g to allow another service to add a configuration file.) Note: this is not a blocker for your patch and could be done in a later patch. It is simply a thought that I wanted to share. Best regards, =2D-=20 Arnaud --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCgAuFiEEMgqfJ4U0fby1t860ojLKXoMTiAwFAmd/4MsQHGRzLWFjQG5h bmVpbi5mcgAKCRCiMspegxOIDE/rD/9vIUKmRubYnKSkm6VZL41gBsjjozwBkpbS yo4GX8zD0mrrIfeyZcWkLj5VgUGWkElN+6WV0EM4Q71dAoAbi6NrhMlAY1cv4M9z V+6bHnF0kK7HeM/kRq2dr57E4NXNbwfZ8ysuohiXzHmDiM08xVSKcfUO69S17w8I A52SLgsdHRGQXE8ru4OuqSBahZNCTd3E+/fe73E+loRzXO9IlTCWkLsYzc1GUHY/ gfqThda3mTh/VkS6+2cINA/fDzNx3v4kJWzPMsg+00WaPwp5AP322JoGMo8TIX7d +y41Fy4PZdLlRGss3gk/ZndPLmdN1RRg6v2ohTahzRfQId8n+ypfqicf3Gp8sS8K lj2u2fvDcdHNQr+M6xd9DPLWFKn2okLEVS+/6mdmIGtMVdgUcazdp35rpfk9zEVg Dc/EQkoq7TA9hJycJN3Oevwt2n9L8BntdhhYMF6EBzWa9jSp4GmNGDxlHHeSlBOJ thQdzZH1hY2UESP6w7N1Z0FmVo4eII19aHfyybvgsoAFg00cwstECFj9ZFHRGVlz 108jfrorXAR7loXG7Yrl1uXw34/sUM1dRt8qoN3YNWYI88sMYt1QfVCm8j7zuRAa f4btbZCI7+ntDPwwffHSYFZs5cyo/SOdhX7XVexz7BOCeZtPP0loLCd3lPsRFo2I 0pQCYc0vlg== =ucdW -----END PGP SIGNATURE----- --=-=-=--