unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 0/1] Fix telepathy-logger build failure
@ 2016-02-23  8:44 Leo Famulari
  2016-02-23  8:44 ` [PATCH 1/1] gnu: telepathy-logger: Disable parallel tests Leo Famulari
  0 siblings, 1 reply; 4+ messages in thread
From: Leo Famulari @ 2016-02-23  8:44 UTC (permalink / raw)
  To: guix-devel

Telepathy-logger hasn't been building on x86_64 and i686:
http://hydra.gnu.org/job/gnu/master/telepathy-logger-0.8.2.x86_64-linux
http://hydra.gnu.org/job/gnu/master/telepathy-logger-0.8.2.i686-linux

Disabling parallel tests fixes it for me on x86_64, and when building
for i686.

Leo Famulari (1):
  gnu: telepathy-logger: Disable parallel tests.

 gnu/packages/freedesktop.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] gnu: telepathy-logger: Disable parallel tests.
  2016-02-23  8:44 [PATCH 0/1] Fix telepathy-logger build failure Leo Famulari
@ 2016-02-23  8:44 ` Leo Famulari
  2016-02-23  8:49   ` Efraim Flashner
  2016-02-28 15:12   ` Ludovic Courtès
  0 siblings, 2 replies; 4+ messages in thread
From: Leo Famulari @ 2016-02-23  8:44 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/freedesktop.scm (telepathy-logger)[arguments]: Disable parallel
tests.
---
 gnu/packages/freedesktop.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index e23cc97..bff709c 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -547,7 +547,8 @@ modems and setup connections with them.")
                 "1bjx85k7jyfi5pvl765fzc7q2iz9va51anrc2djv7caksqsdbjlg"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:phases
+     '(#:parallel-tests? #f
+       #:phases
        (modify-phases %standard-phases
          (add-before 'check 'pre-check
           (lambda _
-- 
2.7.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] gnu: telepathy-logger: Disable parallel tests.
  2016-02-23  8:44 ` [PATCH 1/1] gnu: telepathy-logger: Disable parallel tests Leo Famulari
@ 2016-02-23  8:49   ` Efraim Flashner
  2016-02-28 15:12   ` Ludovic Courtès
  1 sibling, 0 replies; 4+ messages in thread
From: Efraim Flashner @ 2016-02-23  8:49 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

On Tue, 23 Feb 2016 03:44:50 -0500
Leo Famulari <leo@famulari.name> wrote:

> * gnu/packages/freedesktop.scm (telepathy-logger)[arguments]: Disable parallel
> tests.
> ---
>  gnu/packages/freedesktop.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index e23cc97..bff709c 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -547,7 +547,8 @@ modems and setup connections with them.")
>                  "1bjx85k7jyfi5pvl765fzc7q2iz9va51anrc2djv7caksqsdbjlg"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:phases
> +     '(#:parallel-tests? #f
> +       #:phases
>         (modify-phases %standard-phases
>           (add-before 'check 'pre-check
>            (lambda _

this looks fine for pushing

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] gnu: telepathy-logger: Disable parallel tests.
  2016-02-23  8:44 ` [PATCH 1/1] gnu: telepathy-logger: Disable parallel tests Leo Famulari
  2016-02-23  8:49   ` Efraim Flashner
@ 2016-02-28 15:12   ` Ludovic Courtès
  1 sibling, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2016-02-28 15:12 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/freedesktop.scm (telepathy-logger)[arguments]: Disable parallel
> tests.
> ---
>  gnu/packages/freedesktop.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index e23cc97..bff709c 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -547,7 +547,8 @@ modems and setup connections with them.")
>                  "1bjx85k7jyfi5pvl765fzc7q2iz9va51anrc2djv7caksqsdbjlg"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:phases
> +     '(#:parallel-tests? #f

Thanks for fixing it!

In the future it’s even better to add a comment with hints as to why
tests aren’t parallel-safe, if possible.

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-02-28 15:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23  8:44 [PATCH 0/1] Fix telepathy-logger build failure Leo Famulari
2016-02-23  8:44 ` [PATCH 1/1] gnu: telepathy-logger: Disable parallel tests Leo Famulari
2016-02-23  8:49   ` Efraim Flashner
2016-02-28 15:12   ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).