From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] guix package: Add '--list-generations'. Date: Thu, 19 Sep 2013 11:39:07 +0200 Message-ID: <874n9hqhfo.fsf@gnu.org> References: <87vc2o4qwc.fsf@gnu.org> <87eh97616m.fsf@gnu.org> <87bo48xdgb.fsf@karetnikov.org> <87hadz9gze.fsf@gnu.org> <87fvtjdl7y.fsf@karetnikov.org> <87bo444e9q.fsf@gnu.org> <87fvtfzihg.fsf@karetnikov.org> <87ioybxdun.fsf@gnu.org> <877geq9wx6.fsf@karetnikov.org> <87zjrmgcjh.fsf@gnu.org> <87ob80os3c.fsf@karetnikov.org> <87li336ofs.fsf@gnu.org> <87wqmmxutb.fsf@karetnikov.org> <87zjrins47.fsf@gnu.org> <87zjrgok6l.fsf@karetnikov.org> <8738p8wgun.fsf@gnu.org> <87k3ihyq8a.fsf@karetnikov.org> <87ob7tm05z.fsf@gnu.org> <87d2o7q7rj.fsf@karetnikov.org> <87mwn924uc.fsf@gnu.org> <87eh8l63fz.fsf_-_@karetnikov.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMamW-0001kU-Q1 for guix-devel@gnu.org; Thu, 19 Sep 2013 05:44:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMamR-0005CV-4L for guix-devel@gnu.org; Thu, 19 Sep 2013 05:44:16 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:41375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMamQ-0005CQ-Os for guix-devel@gnu.org; Thu, 19 Sep 2013 05:44:11 -0400 In-Reply-To: <87eh8l63fz.fsf_-_@karetnikov.org> (Nikita Karetnikov's message of "Thu, 19 Sep 2013 04:49:20 +0400") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Nikita Karetnikov Cc: guix-devel@gnu.org Nikita Karetnikov skribis: >> Ah so I was referring to recutils record sets (I thought you were >> talking about SRFI-9 records or something.) So what=E2=80=99s the quest= ion? >> :-) > > I was trying to explain why we shouldn=E2=80=99t always output generation= s in > the recutils format. It works for =E2=80=98--search=E2=80=99 because the= re=E2=80=99s only one > record. Ah OK, makes sense. >>> I=E2=80=99m attaching the patch. Please don=E2=80=99t push it yet. I= =E2=80=99ve just found a >>> bug. On my machine, =E2=80=98guix package -p test -l 2d=E2=80=99 and = =E2=80=98guix package -p >>> test -l=E2=80=99 should return the same set of generations, but the fou= rth >>> generation is shown twice in the former case. > >> OK. > > Fixed, but I found a new one. We output a human-readable date but > filter generations based on =E2=80=98ctime=E2=80=99. This may cause prob= lems in some > cases. > > Let me try to demonstrate the problem. > > $ ./pre-inst-env guix package -p test -l > > Generation 1 Sep 16 2013 > Generation 2 Sep 16 2013 > Generation 3 Sep 16 2013 > Generation 4 Sep 16 2013 > Generation 5 Sep 16 2013 > Generation 6 Sep 17 2013 > > And the last two days: > > $ ./pre-inst-env guix package -p test -l 2d > Generation 2 Sep 16 2013 > Generation 3 Sep 16 2013 > Generation 4 Sep 16 2013 > Generation 5 Sep 16 2013 > Generation 6 Sep 17 2013 > > See? Even though the first five generations have the same date, the > first one is not shown. That=E2=80=99s not necessarily a bug: it could be that generation 1 is just slightly more than 48 hours old (the time should also be displayed, I think.) >> I=E2=80=99d use @table rather than @itemize. > > IIUC, it can be used only with the following commands: =E2=80=9C@code, @s= amp, > @var, @option, or @kbd.=E2=80=9D [1] Neither command seems to match. The manual says that @table =E2=80=9Cworks with other commands besides those explicitly mentioned=E2=80=9D, so you could use @emph or @asis. >> s/If you pass/Passing/ >> s/will return/specifies/ > > This doesn=E2=80=99t sound right because the other sentences use =E2=80= =9Cwill.=E2=80=9D This should be present tense overall (for example, s/will print/prints/, s/will output/outputs/, etc.) > Can I push the attached patch to =E2=80=98master=E2=80=99? Yep! Thank you! Ludo=E2=80=99.