From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add AVRDUDE
Date: Thu, 24 Jul 2014 10:21:25 +0200
Message-ID: <874my7xj3u.fsf@gnu.org>
References: <CAFtzXzMrR8mYg6_zL-KbMVrZk0Yr4_zCoFbo9Q2FVtEQRvkR6Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XAEHM-0005um-TU
	for Guix-devel@gnu.org; Thu, 24 Jul 2014 04:21:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XAEHH-0008Sa-IQ
	for Guix-devel@gnu.org; Thu, 24 Jul 2014 04:21:32 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:40147)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XAEHH-0008Rg-Ab
	for Guix-devel@gnu.org; Thu, 24 Jul 2014 04:21:27 -0400
In-Reply-To: <CAFtzXzMrR8mYg6_zL-KbMVrZk0Yr4_zCoFbo9Q2FVtEQRvkR6Q@mail.gmail.com>
	(Manolis Ragkousis's message of "Thu, 24 Jul 2014 08:12:42 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel@gnu.org

Manolis Ragkousis <manolis837@gmail.com> skribis:

> From fe4e8f626bfccc7cbe1d482e53b5a32fe019188a Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Thu, 24 Jul 2014 11:05:43 +0000
> Subject: [PATCH] gnu: Add AVRDUDE
>
> * gnu/packages/avrdude.scm: New file
> * gnu-system.am (GNU_SYSTEM_MODULES): Add avrdude.scm

[...]

> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -37,6 +37,7 @@ GNU_SYSTEM_MODULES =3D				\
>    gnu/packages/autogen.scm			\
>    gnu/packages/autotools.scm			\
>    gnu/packages/avahi.scm			\
> +  gnu/packages/avrdude.scm			\
>    gnu/packages/backup.scm			\
>    gnu/packages/base.scm				\
>    gnu/packages/bash.scm				\

You also need to add the patch in gnu-system.am.

> +    (native-inputs
> +     `(("libelf" ,libelf)
> +       ("libusb" ,libusb)
> +       ("libftdi" ,libftdi)
> +       ("bison" ,bison)
> +       ("flex" ,flex)))

I think only Bison and Flex need to be native inputs (think about
cross-compilation), the rest should be inputs.

> +    (home-page "http://www.nongnu.org/avrdude/")
> +    (synopsis "AVR Downloader/UploaDEr")

Just =E2=80=9CAVR downloader and uploader=E2=80=9D.

> +    (description
> +     "AVRDUDE is an utility to download/upload/manipulate the ROM and
> +EEPROM contents of AVR microcontrollers using the in-system programming
> +technique (ISP)")

Mission period.

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.