Re: [PATCH] gnu: Add AVRDUDE

[ludo@gnu.org (Ludovic Courtès)]

Manolis Ragkousis <manolis837@gmail.com> skribis:

> From fe4e8f626bfccc7cbe1d482e53b5a32fe019188a Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Thu, 24 Jul 2014 11:05:43 +0000
> Subject: [PATCH] gnu: Add AVRDUDE
>
> * gnu/packages/avrdude.scm: New file
> * gnu-system.am (GNU_SYSTEM_MODULES): Add avrdude.scm

[...]

> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -37,6 +37,7 @@ GNU_SYSTEM_MODULES =				\
>    gnu/packages/autogen.scm			\
>    gnu/packages/autotools.scm			\
>    gnu/packages/avahi.scm			\
> +  gnu/packages/avrdude.scm			\
>    gnu/packages/backup.scm			\
>    gnu/packages/base.scm				\
>    gnu/packages/bash.scm				\

You also need to add the patch in gnu-system.am.

> +    (native-inputs
> +     `(("libelf" ,libelf)
> +       ("libusb" ,libusb)
> +       ("libftdi" ,libftdi)
> +       ("bison" ,bison)
> +       ("flex" ,flex)))

I think only Bison and Flex need to be native inputs (think about
cross-compilation), the rest should be inputs.

> +    (home-page "http://www.nongnu.org/avrdude/")
> +    (synopsis "AVR Downloader/UploaDEr")

Just “AVR downloader and uploader”.

> +    (description
> +     "AVRDUDE is an utility to download/upload/manipulate the ROM and
> +EEPROM contents of AVR microcontrollers using the in-system programming
> +technique (ISP)")

Mission period.

Could you send an updated patch?

Thanks,
Ludo’.