From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Thompson Subject: Re: [PATCH 22/31] gnu: Add python-pycrypto. Date: Fri, 05 Sep 2014 15:08:56 -0400 Message-ID: <874mwlrik7.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> References: <1409930317-13220-1-git-send-email-dthompson2@worcester.edu> <1409930317-13220-22-git-send-email-dthompson2@worcester.edu> <8761h13niz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPyse-0004Ld-Je for guix-devel@gnu.org; Fri, 05 Sep 2014 15:09:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPysW-0001Yl-DG for guix-devel@gnu.org; Fri, 05 Sep 2014 15:09:08 -0400 Received: from na3sys009aog111.obsmtp.com ([74.125.149.205]:57186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPysW-0001Yf-6a for guix-devel@gnu.org; Fri, 05 Sep 2014 15:09:00 -0400 Received: by mail-qa0-f46.google.com with SMTP id w8so11341622qac.19 for ; Fri, 05 Sep 2014 12:08:58 -0700 (PDT) In-Reply-To: <8761h13niz.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Eric Bavier Cc: guix-devel@gnu.org Eric Bavier writes: > David Thompson writes: > >> * gnu/packages/python.scm (python-pycrypto, python2-pycrypto): New variables. >> --- >> gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> index 2e16838..886dc03 100644 >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -1598,3 +1598,35 @@ somewhat intelligeble.") >> (define-public python2-pyjwt >> (package-with-python2 python-pyjwt)) >> >> +(define-public python-pycrypto > > As I pointed out on IRC, this package is redundant with the one added in > cafc3f5a. > Thanks for letting me know. Not sure how I missed that. This patch will be dropped. >> + (inputs >> + `(("python" ,python) ;; need libpython3.3m >> + ("python-setuptools" ,python-setuptools) >> + ("gmp" ,gmp))) > > Should python-setuptools perhaps go in native-inputs (this question > applies to the other patches sent in this batch as well)? Not all of > the existing python packages follow this, but maybe they should. > Someone more practiced with cross-compilation might know better. I was wondering about that myself, and also whether to make the test suite dependencies native inputs as well. From what I could tell, using native inputs doesn't work the way you'd hope when using 'package-with-python2'. Not totally sure, though, I didn't explore it very much. Since there's some uncertainty, could we leave setuptools as a regular input for now and address it later? -- David Thompson Web Developer - Free Software Foundation - http://fsf.org GPG Key: 0FF1D807 Support the FSF: https://fsf.org/donate