From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 3/3] gnu: Add mupdf Date: Mon, 15 Sep 2014 08:59:47 +0400 Message-ID: <874mw95vi4.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTOOJ-0003cG-B8 for guix-devel@gnu.org; Mon, 15 Sep 2014 01:00:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTOOA-00056b-6Y for guix-devel@gnu.org; Mon, 15 Sep 2014 00:59:55 -0400 Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:51818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTOO9-00056G-SA for guix-devel@gnu.org; Mon, 15 Sep 2014 00:59:46 -0400 Received: by mail-la0-f43.google.com with SMTP id gi9so3971260lab.30 for ; Sun, 14 Sep 2014 21:59:44 -0700 (PDT) In-Reply-To: (=?utf-8?Q?=22Du=C5=A1an?= Xmetov"'s message of "Sun, 14 Sep 2014 11:15:26 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?Q?Du=C5=A1an?= Xmetov Cc: guix-devel@gnu.org Hello, I don't have real comments, I just noticed a couple of typos. Du=C5=A1an Xmetov (2014-09-14 13:15 +0400) wrote: > From bfe5d62ebe379d9d3b5dde812316f7cefe94ddf5 Mon Sep 17 00:00:00 2001 > From: Marek Benc > Date: Sun, 14 Sep 2014 11:08:10 +0200 > Subject: [PATCH] gnu: Add mupdf > > * gnu/packages/pdf.scm (mupdf): New variable. > * gnu/packages/patches/mupdf-buildsystem-fix.patch: New vile. New file. [...] > +Make use of the above alternatives, compile with gcc. > + > +--- a/Makerules 2014-09-14 09:13:40.729149860 +0200 > ++++ b/Makerules 2014-09-14 09:17:06.425156595 +0200 > +@@ -75,12 +75,14 @@ > +=20 trailing space. > + SYS_FREETYPE_CFLAGS =3D $(shell pkg-config --cflags freetype2) > + SYS_FREETYPE_LIBS =3D $(shell pkg-config --libs freetype2) > +-SYS_OPENJPEG_CFLAGS =3D $(shell pkg-config --cflags libopenjp2) > +-SYS_OPENJPEG_LIBS =3D $(shell pkg-config --libs libopenjp2) > ++SYS_OPENJPEG_CFLAGS =3D $(shell ./ojp2_cppflags.sh) > ++SYS_OPENJPEG_LIBS =3D $(shell ./ojp2_ldflags.sh) > + SYS_JBIG2DEC_LIBS =3D -ljbig2dec > + SYS_JPEG_LIBS =3D -ljpeg > + SYS_ZLIB_LIBS =3D -lz > +=20 trailing space. > ++CC =3D gcc > ++ > + endif > +=20 trailing space. > + # The following section is an example of how to simply do cross-compila= tion > + > +Remove the -x11 from the built binaries, since X11 is implied on GNU. (T= his > +might change when Wayland gets more popular) > + > +--- a/Makefile 2014-06-10 17:09:28.000000000 +0200 > ++++ b/Makefile 2014-09-14 09:57:10.381235299 +0200 > +@@ -255,7 +255,7 @@ > + $(LINK_CMD) > +=20 trailing space. > + ifeq "$(HAVE_X11)" "yes" > +-MUVIEW_X11 :=3D $(OUT)/mupdf-x11 > ++MUVIEW_X11 :=3D $(OUT)/mupdf > + MUVIEW_X11_OBJ :=3D $(addprefix $(OUT)/platform/x11/, x11_main.o x11_im= age.o pdfapp.o) > + $(MUVIEW_X11_OBJ) : $(FITZ_HDR) $(PDF_HDR) > + $(MUVIEW_X11) : $(MUPDF_LIB) $(THIRD_LIBS) > +@@ -263,7 +263,7 @@ > + $(LINK_CMD) $(X11_LIBS) > +=20 trailing space. [...] > + (inputs > + `(("curl" ,curl) > + ("freetype", freetype) ("freetype" ,freetype) [...] > + (synopsis "A lightweight PDF viewer and toolkit.") > + (description > + "MuPDF is a C library that implements a PDF and XPS parsing and re= ndering > +engine. It is used primarily to render pages into bitmaps, but also prov= ides > +support for other operations such as searching and listing the table of > +contents and hyperlinks. > + > +The library ships with a rudimentary X11 viewer, and a set of command li= ne tools > +for batch rendering (pdfdraw), examining the file structure (pdfshow), a= nd > +rewriting files (pdfclean).") > + (license license:agpl3+))) I think people usually avoid a period in a synopsis and use a double space after a period in a description. Also the description should be wrapped by 72 (or 78?) characters in a line.