From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH]: Add CUPS.
Date: Mon, 05 Jan 2015 16:35:57 +0100 [thread overview]
Message-ID: <874ms5qlya.fsf@gnu.org> (raw)
In-Reply-To: <idjy4phz8e3.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Mon, 5 Jan 2015 14:04:04 +0100")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> There are a couple of problems with this package, one of which is that
> the test suite is failing for some reason. I have not been able to
> figure out why the "cupsFileFind" test fails, so I disabled the tests.
OK. Do you have any more details from the test suite log?
> I'm also not sure if creating two outputs "out" and "include" is
> correct. To build OpenJDK with IcedTea I need to have both the library
> output and the include files and after splitting the outputs this worked
> fine.
The reason for splitting would be if it turns out that the include
directory takes a fair amount of space that is not needed in many
cases. If that’s the case, then splitting makes sense. That may well
be the case: what’s the side of each of these outputs?
If it’s just that it happens to fix OpenJDK as a side effect, that’s not
a good reason. :-)
> Finally, I have not actually tried to use CUPS at all, because I only
> really need the libs and headers to build OpenJDK.
OK but that’ll be useful eventually to get Evince and friends to print
correctly.
> + (license license:gpl2+)))
Isn’t it GPLv2-only?
The rest looks good to me.
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-01-05 15:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 13:04 [PATCH]: Add CUPS Ricardo Wurmus
2015-01-05 14:26 ` Thompson, David
2015-01-05 16:38 ` Ricardo Wurmus
2015-01-05 15:35 ` Ludovic Courtès [this message]
2015-01-05 16:48 ` Ricardo Wurmus
2015-01-09 14:57 ` Ricardo Wurmus
2015-01-10 11:32 ` Ludovic Courtès
2015-01-15 16:30 ` Ricardo Wurmus
2015-01-15 20:21 ` Ludovic Courtès
2015-01-05 15:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ms5qlya.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).