From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH]: Add Ant. Date: Thu, 05 Feb 2015 13:32:14 +0100 Message-ID: <874mr05yk1.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJLbZ-0007UQ-Lu for guix-devel@gnu.org; Thu, 05 Feb 2015 07:32:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJLbW-00081T-G6 for guix-devel@gnu.org; Thu, 05 Feb 2015 07:32:21 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJLbW-00081O-Dp for guix-devel@gnu.org; Thu, 05 Feb 2015 07:32:18 -0500 In-Reply-To: (Ricardo Wurmus's message of "Fri, 30 Jan 2015 17:04:10 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus skribis: > this patch adds ant-minimal, a minimal configuration of Apache Ant. Ant > can be configured with lots of optional libraries, but since most of > these libraries are built with Ant, I think it makes sense to provide a > minimal version. Yes. > A wart is that Ant (even in the minimal configuration) depends on > hamcrest-core, which can only be built with Ant. The good news is that > it appears that hamcrest-core is only used for running the tests after > Ant is built. What you did (referring to hamcrest-core.jar) is fine. Turning off tests in ant-minimal would also be fine, IMO; perhaps even preferable, since that avoids another pre-build binary. WDYT? > I used the gnu-build-system instead of the trivial-build-system, because > using the trivial-build-system required me to write a lot more code in > order to unpack the tarball, patch shebangs, add tools to the PATH, > etc. Using the gnu-build-system I only had to remove a few phases to > make it work. Maybe we need a somewhat more powerful version of the > trivial-build-system. Makes sense. > From a8cf4bbd4a8147215a84f27e4aa6247163b4fdf4 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Fri, 30 Jan 2015 16:57:13 +0100 > Subject: [PATCH] gnu: Add Ant. > > * gnu/packages/java.scm (ant-minimal): New variable. > --- > gnu/packages/java.scm | 48 +++++++++++++++++++++++++++++++++++++++++++++= +++ > 1 file changed, 48 insertions(+) > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index 4a86f63..46ff798 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -48,6 +48,54 @@ > #:use-module (gnu packages zip) > #:use-module (gnu packages texinfo)) >=20=20 > +(define-public ant-minimal > + (package > + (name "ant") s/ant/ant-minimal/ Perhaps it could additionally be made private, because users will have no reason to use the minimal variant, no? > + (description > + "Ant is a platform-independent build tool for Java.") Could you expound a bit, saying it=E2=80=99s similar to =E2=80=98make=E2=80= =99, has build recipes written in XML, is especially convenient for Java projects, etc.? I=E2=80=99ll reply to your other comments. Thanks, Ludo=E2=80=99.