From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add powertabeditor.
Date: Fri, 12 Jun 2015 21:39:28 +0200 [thread overview]
Message-ID: <874mmcg1hr.fsf@gnu.org> (raw)
In-Reply-To: <87fv5wkfwd.fsf@elephly.net> (Ricardo Wurmus's message of "Fri, 12 Jun 2015 19:17:02 +0200")
Ricardo Wurmus <rekado@elephly.net> skribis:
> From 18eaadd221e098dfd769cc6aa9c8920730c2674f Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Thu, 4 Jun 2015 10:01:11 +0200
> Subject: [PATCH] gnu: Add powertabeditor.
>
> * gnu/packages/music.scm (powertabeditor): New variable.
> ---
> gnu/packages/music.scm | 98 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 98 insertions(+)
LGTM!
> + ;; CMake appears to lose the RUNPATH for some reason, so it has to be
> + ;; explicitly set with CMAKE_INSTALL_RPATH.
When you have time, it would be good to look at the build log to see all
the -rpath arguments that are passed. It’s a bit scary because it seems
CMake cannot remain under control, somehow. ;-)
Thank you!
Ludo’.
prev parent reply other threads:[~2015-06-12 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 10:08 [PATCH] Add powertabeditor Ricardo Wurmus
2015-06-09 13:32 ` Ludovic Courtès
2015-06-12 17:17 ` Ricardo Wurmus
2015-06-12 19:39 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mmcg1hr.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).