From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] scripts: package: Add --install-from-file option.
Date: Thu, 20 Aug 2015 00:38:58 +0200
Message-ID: <874mju6h4a.fsf@gnu.org>
References: <8737zs78rs.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<87si7ggzsd.fsf@gnu.org>
	<CAJ=RwfbbuF+3i8_6-WkZ7gZArMi4__HHgddFzHPYnG1rGHOeLQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37752)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZSC0e-0005jR-3s
	for guix-devel@gnu.org; Wed, 19 Aug 2015 18:39:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZSC0b-0003c3-Ct
	for guix-devel@gnu.org; Wed, 19 Aug 2015 18:39:03 -0400
In-Reply-To: <CAJ=RwfbbuF+3i8_6-WkZ7gZArMi4__HHgddFzHPYnG1rGHOeLQ@mail.gmail.com>
	(David Thompson's message of "Tue, 18 Aug 2015 20:17:55 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel <guix-devel@gnu.org>

"Thompson, David" <dthompson2@worcester.edu> skribis:

> On Tue, Aug 18, 2015 at 3:30 PM, Ludovic Court=C3=A8s <ludo@gnu.org> wrot=
e:

>>> +  (arguments `(#:configure-flags '("--enable-silent-rules")))
>>> +  (inputs `(("gawk" ,gawk)))
>>
>> I think these two lines can be removed.
>
> Yeah.  BTW, I copy/pasted this from the "Defining Packages" section,
> and that example appears to be broken because it doesn't import the
> (gnu packages gawk) module.

We need to fix it.

> From 471fff182b632fc3b6f99925ff6c7bd25850a841 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Sun, 9 Aug 2015 11:35:51 -0400
> Subject: [PATCH] scripts: package: Add --install-from-file option.
>
> * guix/scripts/package.scm (show-help): Add help text for --install-from-=
file
>   option.
>   (%options): Add --install-from-file option.
> * doc/guix.texi ("invoking guix package"): Document it.
> * doc/package-hello.scm: New file.
> * doc.am (EXTRA_DIST): Add it.

LGTM!

In total sloppiness I forgot to ask you for a test, but you=E2=80=99re welc=
ome
to post it separately.  :-)

I think a couple of lines in tests/guix-package.sh would do, where the
given file would just evaluate to =E2=80=98%bootstrap-guile=E2=80=99 for in=
stance.  How
does that sound?

Thank you,
Ludo=E2=80=99.