Re: [PATCH] scripts: package: Add --install-from-file option.

[ludo@gnu.org (Ludovic Courtès)]

"Thompson, David" <dthompson2@worcester.edu> skribis:

> On Tue, Aug 18, 2015 at 3:30 PM, Ludovic Courtès <ludo@gnu.org> wrote:

>>> +  (arguments `(#:configure-flags '("--enable-silent-rules")))
>>> +  (inputs `(("gawk" ,gawk)))
>>
>> I think these two lines can be removed.
>
> Yeah.  BTW, I copy/pasted this from the "Defining Packages" section,
> and that example appears to be broken because it doesn't import the
> (gnu packages gawk) module.

We need to fix it.

> From 471fff182b632fc3b6f99925ff6c7bd25850a841 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Sun, 9 Aug 2015 11:35:51 -0400
> Subject: [PATCH] scripts: package: Add --install-from-file option.
>
> * guix/scripts/package.scm (show-help): Add help text for --install-from-file
>   option.
>   (%options): Add --install-from-file option.
> * doc/guix.texi ("invoking guix package"): Document it.
> * doc/package-hello.scm: New file.
> * doc.am (EXTRA_DIST): Add it.

LGTM!

In total sloppiness I forgot to ask you for a test, but you’re welcome
to post it separately.  :-)

I think a couple of lines in tests/guix-package.sh would do, where the
given file would just evaluate to ‘%bootstrap-guile’ for instance.  How
does that sound?

Thank you,
Ludo’.