From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: "M-x guix" - magit-like interface for guix commands Date: Sat, 29 Aug 2015 18:01:52 +0200 Message-ID: <874mjiozgv.fsf@gnu.org> References: <87zj1u704r.fsf@gmail.com> <87h9nngjfh.fsf@gnu.org> <87y4gywbrz.fsf@gmail.com> <871tenu51t.fsf@gnu.org> <877fof41n6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZViZp-0001KK-6g for guix-devel@gnu.org; Sat, 29 Aug 2015 12:01:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZViZo-00005E-2e for guix-devel@gnu.org; Sat, 29 Aug 2015 12:01:57 -0400 In-Reply-To: <877fof41n6.fsf@gmail.com> (Alex Kost's message of "Fri, 28 Aug 2015 23:08:13 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alex Kost skribis: > Ludovic Court=C3=A8s (2015-08-28 12:37 +0300) wrote: [...] >> Of course, you=E2=80=99re effectively the maintainer of that part. > > OK, but I also made some changes outside "emacs" dir: Right, thanks for the heads-up then. ;-) > - I exported stuff from (guix scripts lint) and (guix scripts graph): > so that when a user choose "--checkers" option for 'guix lint' or Regarding: Author: Alex Kost AuthorDate: Wed Aug 12 14:17:44 2015 +0300 Commit: Alex Kost CommitDate: Fri Aug 28 23:03:58 2015 +0300 guix lint: Export checkers and accessors. * guix/scripts/lint.scm (%checkers, make-lint-checker, lint-checker, lint-checker?, lint-checker-name, lint-checker-description, lint-checker-check): Export. This is fine, but please don=E2=80=99t export =E2=80=98make-lint-checker=E2= =80=99 (people should use the nicer =E2=80=98lint-checker=E2=80=99 macro instead.) > - I moved emacs info node from "Package Management" to "Top" because it > is not just about package management anymore (as there are > "guix-prettify" and shell completions, and now there is also popup > interface for all guix commands). Regarding: Author: Alex Kost AuthorDate: Thu Aug 13 20:16:29 2015 +0300 Commit: Alex Kost CommitDate: Fri Aug 28 23:03:59 2015 +0300 doc: Reorganize "Emacs Interface" node. * doc/guix.texi (Package Management): Move "Emacs Interface" node to = ... (Top): ...here, since it is not just about package management. * doc/emacs.texi: Shift all nodes one level up (@section -> @chapter,= etc.). Rename "Emacs Usage" node into "Emacs Package Management". Move "E= macs Configuration" node here. It sounds good to me. Perhaps add something like this in this commit: --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- a/doc/guix.texi +++ b/doc/guix.texi @@ -972,9 +972,9 @@ features. This chapter describes the main features of Guix, as well as the package management tools it provides. Two user interfaces are provided for -routine package management tasks: a command-line interface -(@pxref{Invoking guix package, @code{guix package}}), and a visual user -interface in Emacs (@pxref{Emacs Interface}). +routine package management tasks: A command-line interface described below +(@pxref{Invoking guix package, @code{guix package}}), as well as a visual user +interface in Emacs described in a subsequent chapter (@pxref{Emacs Interface}). @menu * Features:: How Guix will make your life brighter. --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > - And finally I moved a part of code from 'guix-main' to a new > 'run-guix' procedure (in (guix ui) module). Regarding: Author: Alex Kost AuthorDate: Sun Aug 16 10:28:04 2015 +0300 Commit: Alex Kost CommitDate: Fri Aug 28 23:03:59 2015 +0300 ui: Add 'run-guix'. * guix/ui.scm (guix-main): Move the code to run guix command line to = ... (run-guix): ...here. New procedure. Export it. [...] +(define (run-guix . args) + "Run guix command defined by command line ARGS." Missing =E2=80=9Cthe=E2=80=9D (=E2=80=9CRun the 'guix' command=E2=80=9D.) = Also please add something like, =E2=80=9CUnlike =E2=80=98guix-main=E2=80=99, this procedure assumes t= hat locale, i18n support, and signal handling has already been set up.=E2=80=9D > As for the emacs part: many long options don't have short analogs, so I > chose keys (for popup windows) that seem appropriate for me, but they > may not be good defaults for others. The same thing with guix commands. > For example, I chose "p" for "package", "P" for "pull" and "u" for > "publish"; or "s" for "system" and "z" for "size", etc. But maybe it is > OK for now, and may be fixed later, if people will complain about > strange popup keys, WDYT? At first sight that looks good to me, because it uses the first letter of the most common commands (=E2=80=98package=E2=80=99 vs. =E2=80=98pull=E2= =80=99, =E2=80=98system=E2=80=99 vs. =E2=80=98size=E2=80=99, etc.) But we can always adjust them later if needed. > Also perhaps there are too many auxiliary commits (add this, add that), > not sure if it's acceptable. That=E2=80=99s OK. Besides, this commit: References: wip-emacs-popup-ui origin/wip-emacs-popup-ui Author: Alex Kost AuthorDate: Tue Aug 18 11:32:42 2015 +0300 Commit: Alex Kost CommitDate: Fri Aug 28 23:04:00 2015 +0300 emacs: Use popup interface instead 'guix-pull' command. * emacs/guix-base.el (guix-pull): Remove. * doc/emacs.texi (Emacs Commands): Adjust accordingly. * emacs/guix-main.scm: Do not use (guix scripts pull) module. removes M-x guix-pull. But that means that people who don=E2=80=99t have magit-popup no longer have a way to run that command, which I=E2=80=99d lik= e to avoid. Is it possible to keep it? > Yes, I think so. I have rebased "wip-emacs-popup-ui" branch on master > and made some final tweaks. So this is the last warning! :-) If you > still don't have comments/notes, I'm ready to push these commits. Well thanks for insisting, now you have a bunch of actions to take. ;-) Cheers, Ludo=E2=80=99. --=-=-=--