> - And finally I moved a part of code from 'guix-main' to a new > 'run-guix' procedure (in (guix ui) module). Regarding: Author: Alex Kost AuthorDate: Sun Aug 16 10:28:04 2015 +0300 Commit: Alex Kost CommitDate: Fri Aug 28 23:03:59 2015 +0300 ui: Add 'run-guix'. * guix/ui.scm (guix-main): Move the code to run guix command line to ... (run-guix): ...here. New procedure. Export it. [...] +(define (run-guix . args) + "Run guix command defined by command line ARGS." Missing “the” (“Run the 'guix' command”.) Also please add something like, “Unlike ‘guix-main’, this procedure assumes that locale, i18n support, and signal handling has already been set up.” > As for the emacs part: many long options don't have short analogs, so I > chose keys (for popup windows) that seem appropriate for me, but they > may not be good defaults for others. The same thing with guix commands. > For example, I chose "p" for "package", "P" for "pull" and "u" for > "publish"; or "s" for "system" and "z" for "size", etc. But maybe it is > OK for now, and may be fixed later, if people will complain about > strange popup keys, WDYT? At first sight that looks good to me, because it uses the first letter of the most common commands (‘package’ vs. ‘pull’, ‘system’ vs. ‘size’, etc.) But we can always adjust them later if needed. > Also perhaps there are too many auxiliary commits (add this, add that), > not sure if it's acceptable. That’s OK. Besides, this commit: References: wip-emacs-popup-ui origin/wip-emacs-popup-ui Author: Alex Kost AuthorDate: Tue Aug 18 11:32:42 2015 +0300 Commit: Alex Kost CommitDate: Fri Aug 28 23:04:00 2015 +0300 emacs: Use popup interface instead 'guix-pull' command. * emacs/guix-base.el (guix-pull): Remove. * doc/emacs.texi (Emacs Commands): Adjust accordingly. * emacs/guix-main.scm: Do not use (guix scripts pull) module. removes M-x guix-pull. But that means that people who don’t have magit-popup no longer have a way to run that command, which I’d like to avoid. Is it possible to keep it? > Yes, I think so. I have rebased "wip-emacs-popup-ui" branch on master > and made some final tweaks. So this is the last warning! :-) If you > still don't have comments/notes, I'm ready to push these commits. Well thanks for insisting, now you have a bunch of actions to take. ;-) Cheers, Ludo’.