From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/3] gnu: Add cmus.
Date: Wed, 21 Oct 2015 21:35:23 +0200
Message-ID: <874mhk816s.fsf@gnu.org>
References: <1445253649-1582-1-git-send-email-paul@denknerd.org>
	<1445253649-1582-3-git-send-email-paul@denknerd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50224)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZozAY-0007AZ-Ag
	for guix-devel@gnu.org; Wed, 21 Oct 2015 15:35:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZozAV-0005Rc-04
	for guix-devel@gnu.org; Wed, 21 Oct 2015 15:35:30 -0400
In-Reply-To: <1445253649-1582-3-git-send-email-paul@denknerd.org> (Paul van
	der Walt's message of "Mon, 19 Oct 2015 13:20:49 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Paul van der Walt <paul@denknerd.org>
Cc: guix-devel@gnu.org

Paul van der Walt <paul@denknerd.org> skribis:

> * gnu/packages/music.scm (cmus): New variable.

[...]

> +     `(#:tests?
> +       #f                               ; cmus does not include tests

Should be on one line.

> +              ;; It's an idiosyncratic configure script that doesn't
> +              ;; understand --prefix=3D..; it wants prefix=3D.. instead.
> +              (setenv "CONFIG_SHELL" (which "bash"))

It probably doesn=E2=80=99t honor =E2=80=98CONFIG_SHELL=E2=80=99 either, in=
 which case this line
can be removed.

> +       ("pkg-config" ,pkg-config)

Should be =E2=80=98native-inputs=E2=80=99.

> +     (home-page "https://cmus.github.io/")
> +     (synopsis "Small, fast and powerful console music player")

=E2=80=9CSmall console music player=E2=80=9D?

> +     (description "Cmus is a small, fast and powerful console music play=
er for
> +Unix-like operating systems.")

What about something like:

  Cmus is a small and fast console music player.  It supports many
  input formats and output options and provides a customizable Vi-style
  user interface.

OK with these changes!

Ludo=E2=80=99.