From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: guile: Add guile-irregex.
Date: Fri, 06 Nov 2015 16:15:18 +0100
Message-ID: <874mgzjh15.fsf@gnu.org>
References: <87egg3dy0f.fsf@dustycloud.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44355)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zuijc-00060K-Jq
	for guix-devel@gnu.org; Fri, 06 Nov 2015 10:15:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZuijY-00041j-Ip
	for guix-devel@gnu.org; Fri, 06 Nov 2015 10:15:24 -0500
In-Reply-To: <87egg3dy0f.fsf@dustycloud.org> (Christopher Allan Webber's
	message of "Fri, 06 Nov 2015 08:03:57 -0600")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel <guix-devel@gnu.org>

Christopher Allan Webber <cwebber@dustycloud.org> skribis:

> On a side note, it would really be nice to have a
> r6rs-build-system... starting to result in a lot of similar spaghetti in
> a few of these packages.

Is there really a standard R6 way of doing things?

I agree some factorization would be welcome anyhow!

> From 38edbac8ab42e1518424fd2da4d53ece2c96094c Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Thu, 5 Nov 2015 12:20:03 -0600
> Subject: [PATCH] gnu: guile: Add guile-irregex.
>
> * gnu/packages/guile.scm (guile-irregex): New variable.

[...]

> +     `(#:modules ((guix build utils)
> +                  (ice-9 match)
> +                  ,@%gnu-build-system-modules)

I think (guix build gnu-build-system) is enough on the 3rd line.

> +    (synopsis "S-expression based regular expressions, packaged for Guil=
e")

I=E2=80=99d remove =E2=80=9C, packaged for Guile=E2=80=9D.

Otherwise LGTM, thank you!

Ludo=E2=80=99.