From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 2/3] emacs: Set 'guix-buffer-item' before displaying entries. Date: Mon, 22 Feb 2016 22:48:40 +0300 Message-ID: <874md0zftz.fsf@gmail.com> References: <1455390283-3585-1-git-send-email-alezost@gmail.com> <1455390283-3585-3-git-send-email-alezost@gmail.com> <871t85u3a0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXwTP-0008Al-EY for guix-devel@gnu.org; Mon, 22 Feb 2016 14:48:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXwTL-0007to-G1 for guix-devel@gnu.org; Mon, 22 Feb 2016 14:48:47 -0500 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2016-02-22 01:06 +0300) wrote: > Alex Kost skribis: > >> * emacs/guix-buffer.el (guix-buffer-set): Set 'guix-buffer-item' early, >> so that it can be used during displaying entries. For example, this >> allows to use a value of the current guix profile when package entries >> are inserted in a "List" or "Info" buffer. > > I don=E2=80=99t fully grasp the details but I trust you. :-) Thanks, this one-line change should be harmless :) > Could you move the explanation as a comment in the code? OK, I added some explanation to the code. > Grammar nitpicking: =E2=80=9Callow NOUN to use bla=E2=80=9D, like =E2=80= =9Callows us to use a > value.=E2=80=9D :-) Thanks! I didn't know this fact. I've pushed this patchset, thanks for the comments! --=20 Alex