unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] emacs: Set 'guix-buffer-item' before displaying entries.
Date: Mon, 22 Feb 2016 22:48:40 +0300	[thread overview]
Message-ID: <874md0zftz.fsf@gmail.com> (raw)
In-Reply-To: 871t85u3a0.fsf@gnu.org

Ludovic Courtès (2016-02-22 01:06 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> * emacs/guix-buffer.el (guix-buffer-set): Set 'guix-buffer-item' early,
>>   so that it can be used during displaying entries.  For example, this
>>   allows to use a value of the current guix profile when package entries
>>   are inserted in a "List" or "Info" buffer.
>
> I don’t fully grasp the details but I trust you.  :-)

Thanks, this one-line change should be harmless :)

> Could you move the explanation as a comment in the code?

OK, I added some explanation to the code.

> Grammar nitpicking: “allow NOUN to use bla”, like “allows us to use a
> value.”  :-)

Thanks!  I didn't know this fact.

I've pushed this patchset, thanks for the comments!

-- 
Alex

  reply	other threads:[~2016-02-22 19:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-13 19:04 [PATCH 0/3] emacs: Few improvements Alex Kost
2016-02-13 19:04 ` [PATCH 1/3] emacs: Add 'M-x guix-installed-{user/system}-packages' Alex Kost
2016-02-21 22:03   ` Ludovic Courtès
2016-02-13 19:04 ` [PATCH 2/3] emacs: Set 'guix-buffer-item' before displaying entries Alex Kost
2016-02-21 22:06   ` Ludovic Courtès
2016-02-22 19:48     ` Alex Kost [this message]
2016-02-13 19:04 ` [PATCH 3/3] emacs: Do not allow to modify system profiles Alex Kost
2016-02-21 22:07   ` Ludovic Courtès
2016-02-23 10:55     ` Pjotr Prins
2016-02-24 16:52       ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874md0zftz.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).