From: Andy Wingo <wingo@igalia.com>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v4] Add hplip
Date: Wed, 23 Mar 2016 09:45:05 +0100 [thread overview]
Message-ID: <874mbxshv2.fsf@igalia.com> (raw)
In-Reply-To: <20160322201207.790bd384@scratchpost.org> (Danny Milosavljevic's message of "Tue, 22 Mar 2016 20:12:07 +0100")
Hi!
Thank you for the quick reactions on the formatting. I know it can be
irritating, but in the future things will be much smoother :)
Just a couple additional fixes.
On Tue 22 Mar 2016 20:12, Danny Milosavljevic <dannym@scratchpost.org> writes:
> + (build-system gnu-build-system)
> + (home-page "http://hplipopensource.com/")
> + (synopsis "HP Printer Drivers")
> + (description "Hewlett-Packard Printer Drivers and PPDs.")
> + (license (list license:gpl2 license:bsd-3)) ; FIXME and which MIT
> + ;; FIXME remove proprietary plug-in installer, hp-plugin (plugin.py)
> + ;; FIXME PPDs use "hpcups" in cupsFilter. In which directory?
> + ;; TODO install apparmor profile files
Probably you will need to fix the plug-in installer issue before adding
to Guix. For the other ones, the style is to write complete sentences
in comments starting with ";;", including "." at the end.
> + (arguments
> + `(#:configure-flags
> + `("--disable-network-build"
> + ,(string-append "--prefix=" (assoc-ref %outputs "out"))
> + ,(string-append "--sysconfdir=" (assoc-ref %outputs "out") "/etc")
> + ;; Disable until mime.types merging works (FIXME)
> + "--disable-fax-build"
> + ,(string-append "--with-cupsfilterdir="
> + (assoc-ref %outputs "out")
> + "/lib/cups/filter") ; TODO merge
> + ,(string-append "--with-cupsbackenddir="
> + (assoc-ref %outputs "out")
> + "/lib/cups/backend") ; TODO merge
> + ,(string-append "--with-icondir="
> + (assoc-ref %outputs "out")
> + "/share/applications") ; TODO merge
> + ,(string-append "--with-systraydir="
> + (assoc-ref %outputs "out")
> + "/etc/xdg")) ; TODO merge
With regards to "TODO merge", that is something to be done outside the
package -- either in the service, or when building a profile. Please
remove these comments and instead be at peace with installing things in
#$out :)
> + #:phases (modify-phases %standard-phases
> + (add-after 'unpack 'fix-libusb
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (substitute* "base/g.py"
> + (("'/etc/hp/hplip.conf'")
> + (string-append "'" out
> + "/etc/hp/hplip.conf" "'")))
Can you re-indent? It should look like this:
(substitute* filename
((pattern)
substitution))
FWIW, in emacs, the .dir-locals.el should add rules to make C-M-q do
this automatically.
> + ; Python3 support is available starting from HPLIP-3.15.2
";;" and a full stop please.
Thank you again for your patience!
Andy
next prev parent reply other threads:[~2016-03-23 8:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 18:12 Using cups Danny Milosavljevic
2016-03-13 22:10 ` Ludovic Courtès
2016-03-15 20:05 ` Danny Milosavljevic
2016-03-15 21:19 ` hplip package (work in progress) Danny Milosavljevic
2016-03-16 8:19 ` Andy Wingo
2016-03-16 8:45 ` Andy Wingo
2016-03-20 0:19 ` Danny Milosavljevic
2016-03-21 22:07 ` [PATCH v2] Add hplip Danny Milosavljevic
2016-03-22 8:28 ` Andy Wingo
2016-03-22 10:30 ` [PATCH v3] " Danny Milosavljevic
2016-03-22 10:56 ` Andy Wingo
2016-03-22 19:12 ` [PATCH v4] " Danny Milosavljevic
2016-03-22 23:51 ` cups-service Danny Milosavljevic
2016-03-23 0:40 ` cups-service Danny Milosavljevic
2016-03-23 9:07 ` cups-service v2 Danny Milosavljevic
2016-04-29 15:09 ` Ludovic Courtès
2016-03-23 8:45 ` Andy Wingo [this message]
2016-03-23 9:39 ` [PATCH v5] Add hplip Danny Milosavljevic
2016-03-23 11:36 ` [PATCH v6] " Danny Milosavljevic
2016-03-23 20:46 ` Efraim Flashner
2016-03-23 23:56 ` [PATCH v7] " Danny Milosavljevic
2016-04-04 21:45 ` Ludovic Courtès
2016-04-10 20:57 ` Danny Milosavljevic
2016-04-29 15:07 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mbxshv2.fsf@igalia.com \
--to=wingo@igalia.com \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).