From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roel Janssen <roel@gnu.org>
Subject: Re: [PATCH] gnu: Add xz-java.
Date: Mon, 04 Apr 2016 14:32:41 +0200
Message-ID: <874mbhd05y.fsf@gnu.org>
References: <87y48yxrew.fsf@gnu.org>
	<idjd1q98y2l.fsf@bimsb-sys02.mdc-berlin.net>
	<87wpoh1sfz.fsf@gnu.org>
	<idj7fgh8pma.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42759)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1an3g8-0002Fm-91
	for guix-devel@gnu.org; Mon, 04 Apr 2016 08:32:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1an3g5-0001JY-1y
	for guix-devel@gnu.org; Mon, 04 Apr 2016 08:32:24 -0400
In-reply-to: <idj7fgh8pma.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org


Ricardo Wurmus writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> One minor detail is the filename of the jar.  I renamed it to
>> "xz-1.5.jar", which I think is the "standard" file naming scheme for our
>> Java packages.
>
> I think it’s a bit ugly because we have the version number in the target
> directory already, but I realise that this is how the jar is originally
> named, so I think that’s okay.

The jar is originally named "xz.jar".  I thought other Java packages
included the version number in the filename, so I just followed this
practice.

Either "xz.jar" or "xz-1.5.jar" is fine with me.

> However, we should not hardcode the version string.  Instead we should
> do something like this (untested):
>
>     #:jar-name ,(string-append "xz-" version ".jar")
>
> What do you think?  If this works for you I’ll commit your patch with
> this change.

I've just tested it and it works.  Since you're better at making a
stylistic decision, I want to leave it up to you whether you want to
append the version number or not.  Both ways are fine with me.

Thanks for your time.

Kind regards,
Roel Janssen