From mboxrd@z Thu Jan 1 00:00:00 1970 From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer?=) Subject: Re: [PATCH] gnu: Add higan. Date: Tue, 07 Jun 2016 22:08:48 +0300 Message-ID: <874m9495q7.fsf@T420.taylan> References: <87fustalcn.fsf@T420.taylan> <878tyh81c4.fsf@T420.taylan> <20160607182938.GD5795@debian-netbook> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAMMy-0001ZW-QI for guix-devel@gnu.org; Tue, 07 Jun 2016 15:08:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAMMu-0004AA-D9 for guix-devel@gnu.org; Tue, 07 Jun 2016 15:08:55 -0400 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:38742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAMMu-00049w-5i for guix-devel@gnu.org; Tue, 07 Jun 2016 15:08:52 -0400 Received: by mail-wm0-x232.google.com with SMTP id m124so127331156wme.1 for ; Tue, 07 Jun 2016 12:08:52 -0700 (PDT) In-Reply-To: <20160607182938.GD5795@debian-netbook> (Efraim Flashner's message of "Tue, 7 Jun 2016 21:29:38 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org Efraim Flashner writes: > On Tue, Jun 07, 2016 at 06:28:59PM +0300, Taylan Ulrich Bay=C4=B1rl=C4=B1= /Kammer wrote: >> If there are no comments, I'll just push this soon, and issues can be >> fixed later; at least it builds and runs fine. :-) >>=20 >> Taylan >>=20 >>=20 >> taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") write= s: >>=20 >> > Some things to note about this package & questions: >> > >> > - There's no official VCS repo and the author doesn't want automated >> > tools to download files from his homepage; there's an unofficial git >> > repo at GitLab but I found it unsuitable so I'm hosting the sources >> > specifically for Guix at GitHub now: >> > > > it does list http://download.byuu.org/higan_v098-source.7z and it lists > the git repo at https://gitlab.com/higan/higan , which only there says > its the unofficial one. The author doesn't wish for build tools to download tarballs from the site. From a thread on the BBS forum: | I don't want people writing build scripts that fetch the source from | byuu.org. I change file names and directory structures all the time, | and I don't want that breaking people's builds. | I would rather distributions host their own repositories of build | files. And for that, you're welcome to store higan in .tar.xz format | instead of .7z format. The linked GitLab repo could be said to be semi-official, but I noted that it doesn't tag releases very consistently. E.g. there's no tag for the latest release. >> > https://github.com/TaylanUB/higan >> > >> > Is this OK, or is there a place we can upload the original source >> > bundle for Guix to download from? >> > >> > - I forgot if there's a guideline for this: the release versions are >> > called 'v097', 'v098' etc. with always a 'v' in front. Should that >> > 'v' appear in the version field of the package or should it be >> > stripped? > > This one I have some insight for. Vapoursynth numbers all their versions > R28, R29, etc. Its version is 29, with the download as `... name "-R" > version ...' Ah good, I'll strip the 'v' then. >> > - As seems to be tradition among emulator developers, the build system >> > and the program's handling of the file system are a big pile of poo, >> > so: >> > >> > * Is it principally OK to reuse the standard `build' and `install' >> > phase procedures a second time, just with the CWD changed, as I do >> > here? > > that should be ok Thanks for the review. :-) Taylan