Re: [PATCH] New package: Seren

[Alex Kost <alezost@gmail.com>]

Francesco Frassinelli (2016-07-19 15:51 +0300) wrote:

> Il giorno lun, 04/07/2016 alle 09.56 +0300, Alex Kost ha scritto:
>> Francesco Frassinelli (2016-05-05 17:34 +0300) wrote:
>> 
>> > I'm a new Guix user and I created a package for Seren, a P2P VoIP
>> > conference program which uses Opus as codec.
>> 
>> Ping!  Hello again, are you willing to send an updated patch, putting
>> 'seren' in "gnu/packages/telephony.scm" and making other changes
>> according to
>> <http://lists.gnu.org/archive/html/guix-devel/2016-05/msg00173.html>?
>> 
>> Sorry for bothering, your patch is mostly OK, but it would be nice if
>> seren was in (gnu packages telephony) module, thanks!
>
> Hi! Here it is! I wasn't able to test properly due to VM Stack Overflow
> error... I'll try to fix my Guix system next week :)

Hi!  If you have some problems, you can ask for help on
<help-guix@gnu.org>.

I think you forgot to Cc guix-devel list, so I do it.

It's not a problem that you didn't test if it can be built, I'll do it,
but... could you send an updated patch?  (See the comments below)

> From 1d51b625a325f0c9ee20602572b441950801df97 Mon Sep 17 00:00:00 2001
> From: Francesco Frassinelli <fraph24@gmail.com>
> Date: Tue, 19 Jul 2016 13:11:48 +0200
> Subject: [PATCH] Add package Seren

Not a big deal, but the commit message should be:

gnu: Add seren.

* gnu/packages/telephony.scm (seren): New variable.

> ---
>  gnu/packages/seren.scm | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 gnu/packages/seren.scm
>
> diff --git a/gnu/packages/seren.scm b/gnu/packages/seren.scm
> new file mode 100644
> index 0000000..4ebdd07
> --- /dev/null
> +++ b/gnu/packages/seren.scm

Putting it into (gnu packages telephony) module means to put it into
"gnu/packages/telephony.scm" file which already exists.  Sorry for not
being clear about it.

> @@ -0,0 +1,65 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 Francesco Frassinelli <fraph24@gmail.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +(define-module (gnu packages telephony)

I didn't meant this, see above.  In Guile (foo bar baz) module always
means that a module file is "<...>/foo/bar/baz.scm".

> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix licenses)
> +  #:use-module (gnu packages linux)
> +  #:use-module (gnu packages xiph)
> +  #:use-module (gnu packages ncurses)
> +  #:use-module (gnu packages multiprecision))
> +
> +(define-public seren
> +  (package
> +    (name "seren")
> +    (version "0.0.21")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://holdenc.altervista.org/"
> +                                  "seren/downloads/seren-" version
> +                                  ".tar.gz"))
> +              (sha256
> +               (base32
> +                 "06mams6bng7ib7p2zpfq88kdr4ffril9svzc9lprkb0wjgmkglk9"))))
> +    (build-system gnu-build-system)

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (arguments `(#:tests? #f)))))

No, not arguments inside arguments, this should be simply:

       (arguments '(#:tests? #f))  ; no "check" target

> +    (inputs `(("alsa-lib" ,alsa-lib)
> +              ("opus" ,opus)
> +              ("libogg" ,libogg)
> +              ("ncurses" ,ncurses)
> +              ("gmp" ,gmp)))
> +    (synopsis "Simple VoIP program to create conferences from the terminal")
> +    (description
> +     "Seren is a simple VoIP program based on the Opus codec that allows you
> +to create a voice conference from the terminal, with up to 10
> +partecipants, without having to register accounts, exchange emails, or
> +add people to contact lists.
> +
> +All you need to join an existing conference is the host name or IP
> +address of one of the partecipants.
> +
> +Seren creates a dynamic peer-to-peer network of equivalent nodes which
> +exchange text and audio data using a UDP connection, and offers the
> +user the ability to change the quality/bitrate on the fly, encrypt the
> +traffic and record the calls.")
> +    (home-page "http://holdenc.altervista.org/seren/")
> +    (license gpl3+)))

-- 
Alex