From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Review process
Date: Fri, 22 Jul 2016 18:02:48 +0200
Message-ID: <874m7hk6dz.fsf_-_@gnu.org>
References: <579027b7.VHXjhpPxQC3AAmeY%pjotr.public12@email>
	<8760rznoh1.fsf@gnu.org> <20160722004130.GA10340@thebird.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46869)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bQcue-0000WH-Ah
	for guix-devel@gnu.org; Fri, 22 Jul 2016 12:02:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bQcuZ-0003Kd-NB
	for guix-devel@gnu.org; Fri, 22 Jul 2016 12:02:56 -0400
In-Reply-To: <20160722004130.GA10340@thebird.nl> (Pjotr Prins's message of
	"Fri, 22 Jul 2016 02:41:30 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel@gnu.org

Howdy,

Pjotr Prins <pjotr.public12@thebird.nl> skribis:

> On Thu, Jul 21, 2016 at 02:51:38PM +0200, Ludovic Court=C3=A8s wrote:
>> In
>> <https://github.com/pjotrp/guix-notes/blob/master/ELIXIR.org#the-gnu-gui=
x-dance-of-getting-packages-accepted>,
>> you already identified exactly what we were going to say.  :-)
>>=20
>> Namely, why are patches applied in a build phase rather than in
>> =E2=80=98origin=E2=80=99, why is such and such test disabled (one senten=
ce is usually
>> enough), what happens if we set =E2=80=98HOME=E2=80=99 like Ben suggests=
, etc.
>>=20
>> What should we do?  :-)
>
> I think I have covered that both in my writeup and in my response to
> Ben. I think this work should be accepted as is.

I find this unfair.  You are not a newcomer, as proved by the fact that
you=E2=80=99ve already identified weaknesses in the work you submit.

Thus, that you post it anyway can be understood as =E2=80=9CI know this and=
 that
should be done, but I=E2=80=99d rather let you do it on my behalf, kthxbye=
=E2=80=9D.

Or perhaps you=E2=80=99re suggesting that reviews are unnecessary, or that =
the
points we insist on make little sense?

Well, I can tell you that as a user, I very much prefer that people who
add packages to the distro have taken their time to make it lean and
clean.  This QA work that you dislike is a service that we developers do
to users; it=E2=80=99s not something we do for the sake of elitism.

I hope this can clear misunderstandings!

Thanks for your feedback,
Ludo=E2=80=99.