From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add sddm. Date: Sat, 27 Aug 2016 15:22:30 +0100 Message-ID: <874m661ec9.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> References: <20160827140030.13275-1-david@craven.ch> <20160827140030.13275-2-david@craven.ch> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdeVi-0000l0-FO for guix-devel@gnu.org; Sat, 27 Aug 2016 10:23:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdeVd-00041v-BO for guix-devel@gnu.org; Sat, 27 Aug 2016 10:23:02 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdeVb-00040W-0A for guix-devel@gnu.org; Sat, 27 Aug 2016 10:22:57 -0400 In-Reply-To: <20160827140030.13275-2-david@craven.ch> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven , guix-devel@gnu.org David Craven writes: > * gnu/packages/hawaii.scm (sddm): New variable. IMO this should go in display-managers.scm. Even better if we can rename slim.scm first, to avoid moving it later. > + (license license:gpl2))) This should be gpl2+. Additionally there are some expat and CC-BY files according to the LICENSE section of the README. The rest of the patch LGTM, although I have not tried it. Nice work! Marius