From: Marius Bakke <mbakke@fastmail.com>
To: David Craven <david@craven.ch>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add sddm.
Date: Sat, 27 Aug 2016 15:22:30 +0100 [thread overview]
Message-ID: <874m661ec9.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20160827140030.13275-2-david@craven.ch>
David Craven <david@craven.ch> writes:
> * gnu/packages/hawaii.scm (sddm): New variable.
IMO this should go in display-managers.scm.
Even better if we can rename slim.scm first, to avoid moving it later.
> + (license license:gpl2)))
This should be gpl2+. Additionally there are some expat and CC-BY files
according to the LICENSE section of the README.
The rest of the patch LGTM, although I have not tried it.
Nice work!
Marius
next prev parent reply other threads:[~2016-08-27 14:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 14:00 [PATCH] Sddm pam authentication failure David Craven
2016-08-27 14:00 ` [PATCH] gnu: Add sddm David Craven
2016-08-27 14:22 ` Marius Bakke [this message]
2016-08-31 15:31 ` David Craven
2016-08-27 14:00 ` [PATCH] services: Add sddm service David Craven
2016-08-27 16:57 ` [PATCH] Sddm pam authentication failure David Craven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m661ec9.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).