* [PATCH] import: cpan: Use tls to query api.metacpan.org.
@ 2016-08-30 12:57 ng0
2016-08-30 16:49 ` Eric Bavier
0 siblings, 1 reply; 7+ messages in thread
From: ng0 @ 2016-08-30 12:57 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: 0001-import-cpan-Use-tls-to-query-api.metacpan.org.patch --]
[-- Type: text/x-patch, Size: 1914 bytes --]
From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Tue, 30 Aug 2016 12:52:51 +0000
Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
* guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
(cpan-fetch-module)[json-fetch]: Likewise.
---
guix/import/cpan.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
index 213a155..5d393ac 100644
--- a/guix/import/cpan.scm
+++ b/guix/import/cpan.scm
@@ -2,6 +2,7 @@
;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
+;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -83,7 +84,7 @@
"Return the base distribution module for a given module. E.g. the 'ok'
module is distributed with 'Test::Simple', so (module->dist-name \"ok\") would
return \"Test-Simple\""
- (assoc-ref (json-fetch (string-append "http://api.metacpan.org/module/"
+ (assoc-ref (json-fetch (string-append "https://api.metacpan.org/module/"
module))
"distribution"))
@@ -91,7 +92,7 @@ return \"Test-Simple\""
"Return an alist representation of the CPAN metadata for the perl module MODULE,
or #f on failure. MODULE should be e.g. \"Test::Script\""
;; This API always returns the latest release of the module.
- (json-fetch (string-append "http://api.metacpan.org/release/"
+ (json-fetch (string-append "https://api.metacpan.org/release/"
;; XXX: The 'release' api requires the "release"
;; name of the package. This substitution seems
;; reasonably consistent across packages.
--
2.9.3
[-- Attachment #2: Type: text/plain, Size: 70 bytes --]
--
ng0
For non-prism friendly talk find me on http://www.psyced.org
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.
2016-08-30 12:57 [PATCH] import: cpan: Use tls to query api.metacpan.org ng0
@ 2016-08-30 16:49 ` Eric Bavier
2016-08-30 17:16 ` ng0
0 siblings, 1 reply; 7+ messages in thread
From: Eric Bavier @ 2016-08-30 16:49 UTC (permalink / raw)
To: ng0; +Cc: guix-devel
On Tue, 30 Aug 2016 12:57:47 +0000
ng0 <ng0@we.make.ritual.n0.is> wrote:
> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@we.make.ritual.n0.is>
> Date: Tue, 30 Aug 2016 12:52:51 +0000
> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
>
> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
> (cpan-fetch-module)[json-fetch]: Likewise.
> ---
> guix/import/cpan.scm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
> index 213a155..5d393ac 100644
> --- a/guix/import/cpan.scm
> +++ b/guix/import/cpan.scm
> @@ -2,6 +2,7 @@
> ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
> ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
> ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
> +;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
This patch may be one of those cases, discussed recently on the mailing
list, where a copyright addition is not appropriate.
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -83,7 +84,7 @@
> "Return the base distribution module for a given module. E.g. the 'ok'
> module is distributed with 'Test::Simple', so (module->dist-name \"ok\") would
> return \"Test-Simple\""
> - (assoc-ref (json-fetch (string-append "http://api.metacpan.org/module/"
> + (assoc-ref (json-fetch (string-append "https://api.metacpan.org/module/"
> module))
> "distribution"))
>
> @@ -91,7 +92,7 @@ return \"Test-Simple\""
> "Return an alist representation of the CPAN metadata for the perl module MODULE,
> or #f on failure. MODULE should be e.g. \"Test::Script\""
> ;; This API always returns the latest release of the module.
> - (json-fetch (string-append "http://api.metacpan.org/release/"
> + (json-fetch (string-append "https://api.metacpan.org/release/"
> ;; XXX: The 'release' api requires the "release"
> ;; name of the package. This substitution seems
> ;; reasonably consistent across packages.
Otherwise LGTM,
`~Eric
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.
2016-08-30 16:49 ` Eric Bavier
@ 2016-08-30 17:16 ` ng0
2016-08-30 18:26 ` Eric Bavier
0 siblings, 1 reply; 7+ messages in thread
From: ng0 @ 2016-08-30 17:16 UTC (permalink / raw)
To: Eric Bavier; +Cc: guix-devel
Eric Bavier <ericbavier@openmailbox.org> writes:
> On Tue, 30 Aug 2016 12:57:47 +0000
> ng0 <ng0@we.make.ritual.n0.is> wrote:
>
>> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
>> From: ng0 <ng0@we.make.ritual.n0.is>
>> Date: Tue, 30 Aug 2016 12:52:51 +0000
>> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
>>
>> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
>> (cpan-fetch-module)[json-fetch]: Likewise.
>> ---
>> guix/import/cpan.scm | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
>> index 213a155..5d393ac 100644
>> --- a/guix/import/cpan.scm
>> +++ b/guix/import/cpan.scm
>> @@ -2,6 +2,7 @@
>> ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
>> ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
>> ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
>> +;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
>
> This patch may be one of those cases, discussed recently on the mailing
> list, where a copyright addition is not appropriate.
"Discussed recently on the mailing list" is one of those occassions
where I'd like to point out that it is a mailing list and therefore is not
very good in giving information unless you search for them.
If there was a conclusion to a longer discussion, please put it into the
contributing section of the manual, otherwise this will be repeated over
and over again, thanks.
I don't necessarily need this copyright addition, so if it looks
otherwise good, can you remove it for mie before commiting the patch, or
do you want me to send it again?
>> ;;;
>> ;;; This file is part of GNU Guix.
>> ;;;
>> @@ -83,7 +84,7 @@
>> "Return the base distribution module for a given module. E.g. the 'ok'
>> module is distributed with 'Test::Simple', so (module->dist-name \"ok\") would
>> return \"Test-Simple\""
>> - (assoc-ref (json-fetch (string-append "http://api.metacpan.org/module/"
>> + (assoc-ref (json-fetch (string-append "https://api.metacpan.org/module/"
>> module))
>> "distribution"))
>>
>> @@ -91,7 +92,7 @@ return \"Test-Simple\""
>> "Return an alist representation of the CPAN metadata for the perl module MODULE,
>> or #f on failure. MODULE should be e.g. \"Test::Script\""
>> ;; This API always returns the latest release of the module.
>> - (json-fetch (string-append "http://api.metacpan.org/release/"
>> + (json-fetch (string-append "https://api.metacpan.org/release/"
>> ;; XXX: The 'release' api requires the "release"
>> ;; name of the package. This substitution seems
>> ;; reasonably consistent across packages.
>
> Otherwise LGTM,
> `~Eric
--
ng0
For non-prism friendly talk find me on http://www.psyced.org
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.
2016-08-30 17:16 ` ng0
@ 2016-08-30 18:26 ` Eric Bavier
2016-08-30 18:51 ` ng0
2016-08-31 14:19 ` Ludovic Courtès
0 siblings, 2 replies; 7+ messages in thread
From: Eric Bavier @ 2016-08-30 18:26 UTC (permalink / raw)
To: ng0; +Cc: guix-devel
On Tue, 30 Aug 2016 17:16:38 +0000
ng0 <ng0@we.make.ritual.n0.is> wrote:
> Eric Bavier <ericbavier@openmailbox.org> writes:
>
> > On Tue, 30 Aug 2016 12:57:47 +0000
> > ng0 <ng0@we.make.ritual.n0.is> wrote:
> >
> >> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
> >> From: ng0 <ng0@we.make.ritual.n0.is>
> >> Date: Tue, 30 Aug 2016 12:52:51 +0000
> >> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
> >>
> >> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
> >> (cpan-fetch-module)[json-fetch]: Likewise.
> >> ---
> >> guix/import/cpan.scm | 5 +++--
> >> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
> >> index 213a155..5d393ac 100644
> >> --- a/guix/import/cpan.scm
> >> +++ b/guix/import/cpan.scm
> >> @@ -2,6 +2,7 @@
> >> ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
> >> ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
> >> ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
> >> +;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> >
> > This patch may be one of those cases, discussed recently on the mailing
> > list, where a copyright addition is not appropriate.
>
> "Discussed recently on the mailing list" is one of those occassions
> where I'd like to point out that it is a mailing list and therefore is not
> very good in giving information unless you search for them.
> If there was a conclusion to a longer discussion, please put it into the
> contributing section of the manual, otherwise this will be repeated over
> and over again, thanks.
It was simply pointed out that the GNU Coding Standards discusses
trivial vs nontrivial code changes.
> I don't necessarily need this copyright addition, so if it looks
> otherwise good, can you remove it for mie before commiting the patch, or
> do you want me to send it again?
I adjust the patch and pushed it in
7a62263ee50c9e2894ea0e746b89f04e3b6484c3.
Thanks,
`~Eric
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.
2016-08-30 18:26 ` Eric Bavier
@ 2016-08-30 18:51 ` ng0
2016-08-31 14:19 ` Ludovic Courtès
1 sibling, 0 replies; 7+ messages in thread
From: ng0 @ 2016-08-30 18:51 UTC (permalink / raw)
To: Eric Bavier; +Cc: guix-devel
Eric Bavier <ericbavier@openmailbox.org> writes:
> On Tue, 30 Aug 2016 17:16:38 +0000
> ng0 <ng0@we.make.ritual.n0.is> wrote:
>
>> Eric Bavier <ericbavier@openmailbox.org> writes:
>>
>> > On Tue, 30 Aug 2016 12:57:47 +0000
>> > ng0 <ng0@we.make.ritual.n0.is> wrote:
>> >
>> >> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
>> >> From: ng0 <ng0@we.make.ritual.n0.is>
>> >> Date: Tue, 30 Aug 2016 12:52:51 +0000
>> >> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
>> >>
>> >> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
>> >> (cpan-fetch-module)[json-fetch]: Likewise.
>> >> ---
>> >> guix/import/cpan.scm | 5 +++--
>> >> 1 file changed, 3 insertions(+), 2 deletions(-)
>> >>
>> >> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
>> >> index 213a155..5d393ac 100644
>> >> --- a/guix/import/cpan.scm
>> >> +++ b/guix/import/cpan.scm
>> >> @@ -2,6 +2,7 @@
>> >> ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
>> >> ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
>> >> ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
>> >> +;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
>> >
>> > This patch may be one of those cases, discussed recently on the mailing
>> > list, where a copyright addition is not appropriate.
>>
>> "Discussed recently on the mailing list" is one of those occassions
>> where I'd like to point out that it is a mailing list and therefore is not
>> very good in giving information unless you search for them.
>> If there was a conclusion to a longer discussion, please put it into the
>> contributing section of the manual, otherwise this will be repeated over
>> and over again, thanks.
>
> It was simply pointed out that the GNU Coding Standards discusses
> trivial vs nontrivial code changes.
Okay, thanks. I should read more of the coding standards than I already
have.
>> I don't necessarily need this copyright addition, so if it looks
>> otherwise good, can you remove it for mie before commiting the patch, or
>> do you want me to send it again?
>
> I adjust the patch and pushed it in
> 7a62263ee50c9e2894ea0e746b89f04e3b6484c3.
>
> Thanks,
> `~Eric
Thanks
--
ng0
For non-prism friendly talk find me on http://www.psyced.org
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.
2016-08-30 18:26 ` Eric Bavier
2016-08-30 18:51 ` ng0
@ 2016-08-31 14:19 ` Ludovic Courtès
2016-08-31 15:00 ` Eric Bavier
1 sibling, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2016-08-31 14:19 UTC (permalink / raw)
To: Eric Bavier; +Cc: guix-devel
Eric Bavier <ericbavier@openmailbox.org> skribis:
> On Tue, 30 Aug 2016 17:16:38 +0000
> ng0 <ng0@we.make.ritual.n0.is> wrote:
>
>> Eric Bavier <ericbavier@openmailbox.org> writes:
>>
>> > On Tue, 30 Aug 2016 12:57:47 +0000
>> > ng0 <ng0@we.make.ritual.n0.is> wrote:
>> >
>> >> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
>> >> From: ng0 <ng0@we.make.ritual.n0.is>
>> >> Date: Tue, 30 Aug 2016 12:52:51 +0000
>> >> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
>> >>
>> >> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
>> >> (cpan-fetch-module)[json-fetch]: Likewise.
[...]
> I adjust the patch and pushed it in
> 7a62263ee50c9e2894ea0e746b89f04e3b6484c3.
“make check TESTS=tests/cpan.scm” fails on current master. Could you
check if this is related?
TIA! :-)
Ludo’.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.
2016-08-31 14:19 ` Ludovic Courtès
@ 2016-08-31 15:00 ` Eric Bavier
0 siblings, 0 replies; 7+ messages in thread
From: Eric Bavier @ 2016-08-31 15:00 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
On Wed, 31 Aug 2016 16:19:13 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Eric Bavier <ericbavier@openmailbox.org> skribis:
>
> > On Tue, 30 Aug 2016 17:16:38 +0000
> > ng0 <ng0@we.make.ritual.n0.is> wrote:
> >
> >> Eric Bavier <ericbavier@openmailbox.org> writes:
> >>
> >> > On Tue, 30 Aug 2016 12:57:47 +0000
> >> > ng0 <ng0@we.make.ritual.n0.is> wrote:
> >> >
> >> >> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
> >> >> From: ng0 <ng0@we.make.ritual.n0.is>
> >> >> Date: Tue, 30 Aug 2016 12:52:51 +0000
> >> >> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
> >> >>
> >> >> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
> >> >> (cpan-fetch-module)[json-fetch]: Likewise.
>
> [...]
>
> > I adjust the patch and pushed it in
> > 7a62263ee50c9e2894ea0e746b89f04e3b6484c3.
>
> “make check TESTS=tests/cpan.scm” fails on current master. Could you
> check if this is related?
Oops. Fixed in 83ab1a812fc7903abdaabeca2e07bb03f8d25827.
Thanks for catching it.
`~Eric
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-08-31 15:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-30 12:57 [PATCH] import: cpan: Use tls to query api.metacpan.org ng0
2016-08-30 16:49 ` Eric Bavier
2016-08-30 17:16 ` ng0
2016-08-30 18:26 ` Eric Bavier
2016-08-30 18:51 ` ng0
2016-08-31 14:19 ` Ludovic Courtès
2016-08-31 15:00 ` Eric Bavier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).