From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 2/3] gnu: Add wcslib
Date: Wed, 31 Aug 2016 09:42:58 +0300
Message-ID: <874m61fngt.fsf@gmail.com>
References: <1472584872-19300-1-git-send-email-jmd@gnu.org>
	<1472584872-19300-2-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bezEm-0001Qa-SP
	for guix-devel@gnu.org; Wed, 31 Aug 2016 02:43:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bezEi-0007TV-LB
	for guix-devel@gnu.org; Wed, 31 Aug 2016 02:43:03 -0400
In-Reply-To: <1472584872-19300-2-git-send-email-jmd@gnu.org> (John
	Darrington's message of "Tue, 30 Aug 2016 21:21:11 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington (2016-08-30 22:21 +0300) wrote:

> * gnu/packages/astronomy.scm (wcslib): New variable.
> ---
>  gnu/packages/astronomy.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
>
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> index 881e549..53e86c8 100644
> --- a/gnu/packages/astronomy.scm
> +++ b/gnu/packages/astronomy.scm
> @@ -51,3 +51,30 @@ provides many advanced features for manipulating and filtering the information
>  in FITS files.")
>      (license (license:non-copyleft "file://License.txt"
>                            "See License.txt in the distribution."))))
> +
> +(define-public wcslib
> +  (package
> +    (name "wcslib")
> +    (version "5.15")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "ftp://ftp.atnf.csiro.au/pub/software/wcslib/" name "-" version ".tar.bz2"))

As for me, this line is too long, I would write:

          (uri (string-append
                "ftp://ftp.atnf.csiro.au/pub/software/wcslib/"
                name "-" version ".tar.bz2"))

> +       (sha256
> +        (base32 "1s2nig327g4bimd9xshlk11ww09a7mrjmsbpdcd8smsmn2kl1glb"))))
> +    (inputs
> +     `(("cfitsio" ,cfitsio)))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-before 'configure 'patch-/bin/sh
> +                    (lambda _
> +                      (substitute* "makedefs.in"
> +                        (("/bin/sh") "sh")))))))

This phase should end with #t.

> +    (home-page "http://www.atnf.csiro.au/people/mcalabre/WCS")
> +    (synopsis "An implementation of the FITS WCS standard")

I think we don't begin synopses with articles ("guix lint" should report
about it).

> +    (description "The FITS \"World Coordinate System\" (WCS) standard defines
> +keywords and usage that provide for the description of astronomical coordinate
> +systems in a FITS image header.")  
                                    ^^
Please remove trailing spaces

> +    (license license:lgpl3+)))

-- 
Alex