From: Alex Kost <alezost@gmail.com>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] gnu: Add wcslib
Date: Wed, 31 Aug 2016 09:42:58 +0300 [thread overview]
Message-ID: <874m61fngt.fsf@gmail.com> (raw)
In-Reply-To: <1472584872-19300-2-git-send-email-jmd@gnu.org> (John Darrington's message of "Tue, 30 Aug 2016 21:21:11 +0200")
John Darrington (2016-08-30 22:21 +0300) wrote:
> * gnu/packages/astronomy.scm (wcslib): New variable.
> ---
> gnu/packages/astronomy.scm | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
>
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> index 881e549..53e86c8 100644
> --- a/gnu/packages/astronomy.scm
> +++ b/gnu/packages/astronomy.scm
> @@ -51,3 +51,30 @@ provides many advanced features for manipulating and filtering the information
> in FITS files.")
> (license (license:non-copyleft "file://License.txt"
> "See License.txt in the distribution."))))
> +
> +(define-public wcslib
> + (package
> + (name "wcslib")
> + (version "5.15")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "ftp://ftp.atnf.csiro.au/pub/software/wcslib/" name "-" version ".tar.bz2"))
As for me, this line is too long, I would write:
(uri (string-append
"ftp://ftp.atnf.csiro.au/pub/software/wcslib/"
name "-" version ".tar.bz2"))
> + (sha256
> + (base32 "1s2nig327g4bimd9xshlk11ww09a7mrjmsbpdcd8smsmn2kl1glb"))))
> + (inputs
> + `(("cfitsio" ,cfitsio)))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'configure 'patch-/bin/sh
> + (lambda _
> + (substitute* "makedefs.in"
> + (("/bin/sh") "sh")))))))
This phase should end with #t.
> + (home-page "http://www.atnf.csiro.au/people/mcalabre/WCS")
> + (synopsis "An implementation of the FITS WCS standard")
I think we don't begin synopses with articles ("guix lint" should report
about it).
> + (description "The FITS \"World Coordinate System\" (WCS) standard defines
> +keywords and usage that provide for the description of astronomical coordinate
> +systems in a FITS image header.")
^^
Please remove trailing spaces
> + (license license:lgpl3+)))
--
Alex
next prev parent reply other threads:[~2016-08-31 6:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 19:21 [PATCH 1/3] gnu: Add cfitsio John Darrington
2016-08-30 19:21 ` [PATCH 2/3] gnu: Add wcslib John Darrington
2016-08-30 20:47 ` Leo Famulari
2016-08-31 6:42 ` Alex Kost [this message]
2016-09-12 13:44 ` Alex Kost
2016-09-12 15:40 ` John Darrington
2016-09-13 8:10 ` Alex Kost
2016-09-13 12:44 ` John Darrington
2016-08-30 19:21 ` [PATCH 3/3] gnu: Add gnuastro John Darrington
2016-08-30 20:45 ` Leo Famulari
2016-08-31 6:47 ` Alex Kost
2016-08-30 20:47 ` [PATCH 1/3] gnu: Add cfitsio Leo Famulari
2016-08-31 6:45 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m61fngt.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).