unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ng0 <ng0@we.make.ritual.n0.is>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add femtolisp.
Date: Wed, 14 Sep 2016 09:31:26 +0000	[thread overview]
Message-ID: <874m5i3k0h.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <87d1k6etze.fsf@elephly.net>


[-- Attachment #1.1: Type: text/plain, Size: 300 bytes --]

Ricardo Wurmus <rekado@elephly.net> writes:

> Hi,
>
>> I hope the appended patch still applies.
>
> could you please send a new, complete patch?
>
> You seem to have removed the “#t” from the “install” phase
> accidentally.  The return value should be kept.
>
> ~~ Ricardo
>
>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-femtolisp-Adjust-description.patch --]
[-- Type: text/x-patch, Size: 2399 bytes --]

From 7a58278178f7c13b1c9bfc93da4e5c8d765e59a8 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Tue, 13 Sep 2016 20:19:57 +0000
Subject: [PATCH] gnu: femtolisp: Adjust description.

* gnu/packages/lisp.scm (femtolisp)[description]: Adjust to remove
unnecessary sentence.
[arguments](patch-makefile): Remove it and ...
(make-flags): Add "release" to make-flags.
(arguments)[tests]: Enable them as test-target "test".
---
 gnu/packages/lisp.scm | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 3461de4..eb72b96 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -503,19 +503,11 @@ the InterLisp Standard.")
                   "04rnwllxnl86zw8c6pwxznn49bvkvh0f1lfliy085vjzvlq3rgja"))))
       (build-system gnu-build-system)
       (arguments
-       `(#:make-flags '("CC=gcc")
-         #:tests? #f ; No make check
+       `(#:make-flags '("CC=gcc" "release")
+         #:test-target "test"
          #:phases
          (modify-phases %standard-phases
            (delete 'configure) ; No configure script
-           ;; We have to remove the 'test phase because it requires
-           ;; the flisp binary to be present. Instead we run
-           ;; bootstrap.sh after the 'install phase.
-           (add-before 'build 'patch-makefile
-             (lambda _
-               (substitute* "Makefile"
-                 (("default: release test") "default: release"))
-               #t))
            (replace 'install ; Makefile has no 'install phase
             (lambda* (#:key outputs #:allow-other-keys)
               (let* ((out (assoc-ref outputs "out"))
@@ -533,8 +525,8 @@ the InterLisp Standard.")
                  (install-file "flisp.boot" bin))))))))
       (synopsis "Scheme-like lisp implementation")
       (description
-       "@code{femtolisp} is a scheme-like lisp implementation with a
-simple, elegant Scheme dialect.  It is a lisp-1 with lexical scope.
-The core is 12 builtin special forms and 33 builtin functions.")
+       "@code{femtolisp} is a Scheme-like lisp implementation with a
+simple, elegant Scheme dialect.  The core is 12 builtin special forms
+and 33 builtin functions.")
       (home-page "https://github.com/JeffBezanson/femtolisp")
       (license license:bsd-3))))
-- 
2.10.0


[-- Attachment #1.3: Type: text/plain, Size: 26 bytes --]


-- 
              ng0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

  reply	other threads:[~2016-09-14  9:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 19:04 [PATCH 1/2] gnu: Add femtolisp ng0
2016-09-13 19:04 ` [PATCH 2/2] gnu: lispf4: Remove unused inputs key ng0
2016-09-13 19:30 ` [PATCH 1/2] gnu: Add femtolisp Ricardo Wurmus
2016-09-13 19:45   ` ng0
2016-09-13 20:32   ` ng0
2016-09-14  9:00     ` Ricardo Wurmus
2016-09-14  9:31       ` ng0 [this message]
2016-09-14  9:48         ` ng0
2016-09-14 10:03           ` Ricardo Wurmus
2016-09-14 10:15             ` ng0
2016-09-14 11:05               ` Ricardo Wurmus
2016-09-14 11:17                 ` ng0
2016-09-14 12:03                   ` ng0
2016-09-18 10:02                     ` Andreas Enge
2016-09-20  6:14                       ` Ludovic Courtès
2016-09-21 10:37                         ` ng0
2016-09-21 15:33                           ` Ludovic Courtès
2016-09-21 19:30                             ` Ricardo Wurmus
2016-09-22  9:11                         ` [PATCH] gnu: femtolisp: Remove support for mips and armhf ng0
2016-09-26 10:38                           ` Ludovic Courtès
2016-09-27  8:13                             ` ng0
2016-09-27 16:30                               ` Leo Famulari
2016-09-18 12:20                     ` [PATCH 1/2] gnu: Add femtolisp ng0
2016-09-18 12:25                     ` ng0
  -- strict thread matches above, loose matches on Subject: below --
2016-09-12 13:57 ng0
2016-09-13 19:40 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874m5i3k0h.fsf@we.make.ritual.n0.is \
    --to=ng0@we.make.ritual.n0.is \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).