From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 1/4] gnu: Add x265. Date: Wed, 26 Oct 2016 04:31:55 +0100 Message-ID: <874m3zeqfo.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> References: <20161025053932.10328-1-efraim@flashner.co.il> <20161025053932.10328-2-efraim@flashner.co.il> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzEwc-0004Ys-7B for guix-devel@gnu.org; Tue, 25 Oct 2016 23:32:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzEwZ-0002Ee-3p for guix-devel@gnu.org; Tue, 25 Oct 2016 23:32:02 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36649) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzEwY-0002EX-VD for guix-devel@gnu.org; Tue, 25 Oct 2016 23:31:59 -0400 In-Reply-To: <20161025053932.10328-2-efraim@flashner.co.il> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner , guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Efraim Flashner writes: > * gnu/packages/video.scm (x265): New variable. > --- > gnu/packages/video.scm | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index bd82eb8..6000c5b 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -250,6 +250,34 @@ H.264 (MPEG-4 AVC) video streams.") > "file://extras/cl.h" > "See extras/cl.h in the distribution."))))) >=20=20 > +(define-public x265 > + (package > + (name "x265") > + (version "2.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://download.videolan.org/videolan/x265= /" > + "x265_" version ".tar.gz")) > + (sha256 > + (base32 > + "0hx6sr9l7586gs4qds2sj0i1m5brxkaqq3cwmibhfb559fpvkz48")))) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f ; tests are skipped if cpu-optimized code isn't built > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'prepare-build > + (lambda _ > + (delete-file-recursively "build") > + (chdir "source") > + #t))))) > + (home-page "http://x265.org/") > + (synopsis "Library for encoding h.265/HEVC video streams") > + (description "x265 is a H.265 / HEVC video encoder application libra= ry, > +designed to encode video or images into an H.265 / HEVC encoded bitstrea= m.") > + (license license:gpl2+))) The files in compat/getopt/ are lgpl2.1+. Unbundling it would be even better, if possible. Other than that this LGTM! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYECOrAAoJEKKgbfKjOlT6iBAH/3D0n9k6M1kdBYkuBvc1zezY 0aXWw1w+jIWR4rBqhjBHbageFDF1pIcT3Gpz5kgIS545B/2IWPT87xx+40MKcZpl gAZlQzuLI8RoyevrAYuitCMoNlTxqDRI6TB4TzKrWxdQNLF7o7Etj+81agCJ6UFF N7hxe4MBlo/mLWdACobqGIUkR1+FTUkkyBjTzMR6/ZV0mqv2+Xgclm8oLIOjN0Kc hTAzPAMAtGcCEdPk14iT+ktMHwIC79KAo1uZokJoM/ZLLc+/t+KrU0cyMEwY+jIu Dn9Bu6GW+qGbPutf4GN7SRQ6QYO+/3vVAjw3YOXRBBZY0z+4SshmofyWRosdppU= =cJaw -----END PGP SIGNATURE----- --=-=-=--