From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] mps-youtube Date: Wed, 02 Nov 2016 12:34:17 +0000 Message-ID: <874m3qawmu.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> References: <20161102104057.8226-1-ng0@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1ukM-00017a-G2 for guix-devel@gnu.org; Wed, 02 Nov 2016 08:34:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1ukJ-0006wq-Bq for guix-devel@gnu.org; Wed, 02 Nov 2016 08:34:26 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40819) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1ukJ-0006wX-7y for guix-devel@gnu.org; Wed, 02 Nov 2016 08:34:23 -0400 In-Reply-To: <20161102104057.8226-1-ng0@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 , guix-devel@gnu.org --=-=-= Content-Type: text/plain ng0 writes: > I am not sure about how the non-python runtime dependencies are supposed to be handled in python packages. > > python-pafy needs youtube-dl to function. > mps-youtube needs at least mpv and optionally ffmpeg to deal with conversion of formats. Have you checked whether the inputs are referenced in `guix gc -R /gnu/store/...item`? If not, we'll need to make it record the absolute paths of the dependencies somehow. Often this can be done with '--with-foo=(string-append (assoc-ref inputs "foo") "/bin/foo"' in the configure step. Another approach is to substitute those commands with the full path directly in the code. > So far they are in (inputs). Are those supposed to be installed by the users themselves? For optional dependencies (i.e. if mps-youtube gracefully handles missing ffmpeg), leaving it up to the user is good (but then it should not be an input). For "hard" runtime dependencies, the absolute paths must be recorded so that they won't get garbage collected. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYGd1JAAoJEKKgbfKjOlT6tyUIAL9+HvtKI5vy9dF6x1YJxcVp WpwNRs1ZEeJO3dmVBPey6gkWlwAMUd0cxWowD1NMfKGMLoPn7wr5iqkxdE+p9cHi mc4AYOlRLt47FwV59hHmascUJt7Zl7BuANDf1W2JKLUgc6d5BPIjoTi4BgwM3N0/ RLfF8hL80WHkXVscvJUOt+sffqgosfvLP7JjhCUnzis17hJh273GIGhkTC1kFYii SpTlZyE0nD4txGeDt5SoWASVv6K4kq9Zv5axyms0TE2Ag03RVm+7Ovxg7PLKnwGp +hDBmFpyYaFTA5mla+ovxTr2qyk7utNhf1Zhg5qHW6aRI+0r4kXkBZbpZUx3hYU= =uQnF -----END PGP SIGNATURE----- --=-=-=--