Re: [PATCH] mps-youtube

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

ng0 <ng0@we.make.ritual.n0.is> writes:

> I am not sure about how the non-python runtime dependencies are supposed to be handled in python packages.
>
> python-pafy needs youtube-dl to function.
> mps-youtube needs at least mpv and optionally ffmpeg to deal with conversion of formats.

Have you checked whether the inputs are referenced in `guix gc -R
/gnu/store/...item`? If not, we'll need to make it record the absolute
paths of the dependencies somehow. Often this can be done with
'--with-foo=(string-append (assoc-ref inputs "foo") "/bin/foo"' in the
configure step. Another approach is to substitute those commands
with the full path directly in the code.

> So far they are in (inputs). Are those supposed to be installed by the users themselves?

For optional dependencies (i.e. if mps-youtube gracefully handles
missing ffmpeg), leaving it up to the user is good (but then it should
not be an input). For "hard" runtime dependencies, the absolute paths
must be recorded so that they won't get garbage collected.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]