From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] gnu: Add espeak. Date: Tue, 22 Nov 2016 11:26:23 -0500 Message-ID: <874m2zfplc.fsf@openmailbox.org> References: <87fumktptd.fsf@openmailbox.org> <87vavf5zjp.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9Du2-0000ij-7i for guix-devel@gnu.org; Tue, 22 Nov 2016 11:26:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9Dty-0002cj-7W for guix-devel@gnu.org; Tue, 22 Nov 2016 11:26:38 -0500 Received: from smtp13.openmailbox.org ([62.4.1.47]:55596) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c9Dtx-0002cR-S1 for guix-devel@gnu.org; Tue, 22 Nov 2016 11:26:34 -0500 In-Reply-To: <87vavf5zjp.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Tue, 22 Nov 2016 16:01:30 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Marius Bakke writes: > Kei Kebreau writes: > >> I think the patch works fine, but I'd love to hear comments about its >> clarity. > > Hi! Thanks for this patch. The source includes a pre-compiled 32-bit > version in "linux_32bit". Can you remove that with a source snippet? > >> From d1031c30c57eb6f292a91963801f87b419d8bee2 Mon Sep 17 00:00:00 2001 >> From: Kei Kebreau >> Date: Mon, 21 Nov 2016 17:35:00 -0500 >> Subject: [PATCH] gnu: Add espeak. >>=20 >> * gnu/packages/audio.scm (espeak): New variable. >> --- >> gnu/packages/audio.scm | 46 +++++++++++++++++++++++++++++++++++++++++++= +++ >> 1 file changed, 46 insertions(+) >>=20 >> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm >> index 77d3b53..8aba416 100644 >> --- a/gnu/packages/audio.scm >> +++ b/gnu/packages/audio.scm >> @@ -343,6 +343,52 @@ tools (analyzer, mono/stereo tools, crossovers).") >> ;; The plugins are released under LGPLv2.1+ >> (license (list license:lgpl2.1+ license:gpl2+)))) >>=20=20 >> +(define-public espeak >> + (package >> + (name "espeak") >> + (version "1.48.04") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "mirror://sourceforge/espeak/espeak-1= .48/" > > Two comments: The URL should be > "mirror://sourceforge/espeak/espeak/espeak-1.48" (note the extra > "espeak"). > > In addition, you can use the "version-major+minor" procedure instead of > hard coding "1.48" here. > > Other than that this LGTM! > >> + "espeak-" version "-source.zip")) >> + (sha256 >> + (base32 >> + "0n86gwh9pw0jqqpdz7mxggllfr8k0r7pc67ayy7w5z6z79kig6mz")= ))) >> + (build-system gnu-build-system) >> + (arguments >> + `(#:make-flags (list (string-append "PREFIX=3D" (assoc-ref %output= s "out")) >> + (string-append "DATADIR=3D" >> + (assoc-ref %outputs "out") >> + "/share/espeak-data") >> + (string-append "LDFLAGS=3D-Wl,-rpath=3D" >> + (assoc-ref %outputs "out") >> + "/lib") >> + "AUDIO=3Dpulseaudio") >> + #:tests? #f ; no check target >> + #:phases >> + (modify-phases %standard-phases >> + (replace 'configure >> + (lambda _ >> + (chdir "src") >> + ;; We use version 19 of the PortAudio library, so we must = copy the >> + ;; corresponding file to be sure that espeak compiles corr= ectly. >> + (copy-file "portaudio19.h" "portaudio.h") >> + (substitute* "Makefile" >> + (("/bin/ln") "ln")) >> + #t))))) >> + (inputs >> + `(("portaudio" ,portaudio) >> + ("pulseaudio" ,pulseaudio))) >> + (native-inputs `(("unzip" ,unzip))) >> + (home-page "http://espeak.sourceforge.net/") >> + (synopsis "Software speech synthesizer") >> + (description "eSpeak is a software speech synthesizer for Englis= h and >> +other languages. eSpeak uses a \"formant synthesis\" method. This all= ows many >> +languages to be provided in a small size. The speech is clear, and can= be used >> +at high speeds, but is not as natural or smooth as larger synthesizers = which are >> +based on human speech recordings.") >> + (license license:gpl3+))) >> + >> (define-public infamous-plugins >> (package >> (name "infamous-plugins") >> --=20 >> 2.10.2 >>=20 Thanks for the review! Pushed with your suggested changes. :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlg0ca8ACgkQ5qXuPBlG eg07EhAAma+ZvQ3kt5xXlJskmjs5o8UVhyOMaA+LJzVSQbzNXKKHaKW6ocfUUUB/ Rl57VP96yvFBhaYORm6tItaFPEDQKica6Xh8R8F8qh6alnr8G+hFZ6t4YHQCVJn0 IejwJR+83BZBsB2VCkY0J1l5AMWkKxkDZ5HoiZsEtJfqra9rMCFMpWpUb7PTSJvC ql11zK/TJoIUFacjx2xFlkm7Rs3KpzQwazshCJDBzAuB7sILrTMO19atEvBESa0Z Qe+SQqSJ1chDFf74+cxYuJXh3nl0z4H98WQQLSzH8mvL1uAH61R7rHJqJSiEqhcv EtjZtxbhiBpWpMBY+RzgK1FmLM7Ow6Cmgig/8nGJoWuAM5+0nO6c/nGugJFGjxzc RM6XLEsK5co3Y+yCkvYLveYsVOzt3NJkoCJB8CnIIQpAvF05vWUtY5/roGqH30yY tj3MJ6xL8hXi3l1UZuu4YGB/25cYoUlwa87mSUVExKAhyjzbn2HD1wIA+Wf8WJlp w0uTCZ1aSNbcMJRPMcT2hs7tFktk7c5KYimkQqkp6cotRreiihE09vDQKcI1T90r YSmo3IvW5wvKHxNTLkKTxVlgWZZY0nck8Z1TixQ/8Se1IoUeKCwXByoA/5HfUh9n sHKmesnaJcFZCf4EE44OqhxOSjPlXEx8ioOH8r/dIvJQuAvJuNY= =wDNs -----END PGP SIGNATURE----- --=-=-=--