From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH WIP] linux-initrd: Add a raw-initrd and use it to define
	base-initrd.
Date: Wed, 08 Mar 2017 18:28:44 +0100
Message-ID: <874lz3lltf.fsf@gnu.org>
References: <20170307082455.3159-1-m.othacehe@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34595)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1clfON-0000G3-Hz
	for guix-devel@gnu.org; Wed, 08 Mar 2017 12:28:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1clfOK-0007bn-CJ
	for guix-devel@gnu.org; Wed, 08 Mar 2017 12:28:51 -0500
In-Reply-To: <20170307082455.3159-1-m.othacehe@gmail.com> (Mathieu Othacehe's
	message of "Tue, 7 Mar 2017 09:24:55 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: guix-devel@gnu.org

Hi Mathieu,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * gnu/system/linux-initrd.scm (raw-initrd): New exported variable.
> (base-initrd): Use raw-initrd to build the initrd.

Nice!

> It has been discussed here :
> https://lists.gnu.org/archive/html/guix-devel/2016-07/msg01524.html
> and here :
> https://lists.gnu.org/archive/html/guix-devel/2017-02/msg00937.html
>
> As a summary, it is useful if you have a custom kernel config and base-in=
itrd tries
> to include not compiled modules for example.
>
> raw-initrd doesn't try neither to guess which helper-packages should be i=
ncluded
> in the initrd. I'm not sure this is the right thing to do here.
>
> Note I didn't update the doc yet as this is still a draft patch.
>
> What do you think ?

I think it looks good, and definitely an improvement.

So the remaining bits would be:

  1. Making sure =E2=80=98make check-system TESTS=3Dbasic=E2=80=99 or simil=
ar works.

  2. Adding a copyright line for you.  :-)

  3. Updating the doc.

Could you send an updated patch?

Thanks for working on it!

Ludo=E2=80=99.