Re: [PATCH WIP] linux-initrd: Add a raw-initrd and use it to define base-initrd.

[ludo@gnu.org (Ludovic Courtès)]

Hi Mathieu,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * gnu/system/linux-initrd.scm (raw-initrd): New exported variable.
> (base-initrd): Use raw-initrd to build the initrd.

Nice!

> It has been discussed here :
> https://lists.gnu.org/archive/html/guix-devel/2016-07/msg01524.html
> and here :
> https://lists.gnu.org/archive/html/guix-devel/2017-02/msg00937.html
>
> As a summary, it is useful if you have a custom kernel config and base-initrd tries
> to include not compiled modules for example.
>
> raw-initrd doesn't try neither to guess which helper-packages should be included
> in the initrd. I'm not sure this is the right thing to do here.
>
> Note I didn't update the doc yet as this is still a draft patch.
>
> What do you think ?

I think it looks good, and definitely an improvement.

So the remaining bits would be:

  1. Making sure ‘make check-system TESTS=basic’ or similar works.

  2. Adding a copyright line for you.  :-)

  3. Updating the doc.

Could you send an updated patch?

Thanks for working on it!

Ludo’.