From: Kei Kebreau <kei@openmailbox.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add fpc. (version 2)
Date: Mon, 20 Mar 2017 11:02:04 -0400 [thread overview]
Message-ID: <874lyo56vn.fsf@openmailbox.org> (raw)
In-Reply-To: <20170314224527.7bee1241@scratchpost.org> (Danny Milosavljevic's message of "Tue, 14 Mar 2017 22:45:27 +0100")
[-- Attachment #1: Type: text/plain, Size: 2195 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> writes:
> Hi,
>
>>+ (copy-file (assoc-ref inputs "fpc-binary")
>>+ "fpc-bin.tar")
>>+ (zero? (system* "tar" "xvf" "fpc-bin.tar")))))
>
> Why the copy-file and then untar ? Can't it be untarred immediately from where it is? If it is useful, maybe add a comment about the reason.
>
It turns out that this wasn't useful. I can't remember what I wanted to
accomplish by copying the file first, so I've removed the unnecessary call.
> Also, it might be easier to have a fpc-bootstrap package with the
> bootstrap binaries that installs the binaries required to build fpc
> normally and to make a fpc package depend on fpc-bootstrap as
> native-inputs. What do you think? I myself don't have a strong
> preference about it - but some other packages do it that way.
>
This is how I have fpc set up to build right now, unless I'm missing
something. I've defined the bootstrap binaries for the i386 and x86_64
architectures, and the FPC package definition builds the source using
the appropriate binaries depending on the architecture of the build
target.
> About the fpc-reproducibility.patch , it might make sense to file bugs upstream about it so they add it on their side.
>
I'll bring it up to them.
> Also, these existing bootstrap compilers on sourceforge do not produce
> bit reproducible executables, right? Should they also have the same
> patch applied upstream in the future ?
>
The existing bootstrap compilers can produce bit reproducible
executables when they are provided with a program without
environment-dependent variables (time, hostname, etc.). As an example,
the FPC source itself builds reproducibly using the bootstrap FPC binaries.
> Overall LGTM!
>
Thanks for the review!
> fpc supports armhf and usually so do we - although not here. We can add armhf support in a future patch, though.
You know, the FPC has released new binaries for its version 3.0.2
release. Now there are bootstrap binaries available for mips,
arm-eabihf and powerpc as well. I can see about adding those and trying
them out.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-03-20 15:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 22:44 [PATCH] gnu: Add fpc Kei Kebreau
2017-01-27 4:01 ` [PATCH] gnu: Add fpc. (version 2) Kei Kebreau
2017-01-27 4:52 ` Kei Kebreau
2017-01-27 6:00 ` Kei Kebreau
2017-03-12 12:47 ` Danny Milosavljevic
2017-03-13 21:22 ` Kei Kebreau
2017-03-14 21:45 ` Danny Milosavljevic
2017-03-20 15:02 ` Kei Kebreau [this message]
2017-03-20 19:59 ` Ricardo Wurmus
2017-03-20 22:54 ` Kei Kebreau
2017-06-05 13:20 ` Danny Milosavljevic
2017-06-05 13:33 ` Marius Bakke
2017-06-05 13:42 ` Marius Bakke
2017-06-09 1:30 ` Kei Kebreau
2017-06-05 19:55 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lyo56vn.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).