From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: 01/01: build-system/meson: Really skip the 'fix-runpath' phase on armhf. Date: Mon, 02 Jul 2018 20:28:28 +0200 Message-ID: <874lhhwkz7.fsf@fastmail.com> References: <20180702101757.22792.51026@vcs0.savannah.gnu.org> <20180702101758.97A6020543@vcs0.savannah.gnu.org> <8736x1r1g0.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa3Yx-0003i0-Ep for guix-devel@gnu.org; Mon, 02 Jul 2018 14:28:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa3Yt-0004mZ-Gw for guix-devel@gnu.org; Mon, 02 Jul 2018 14:28:35 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35521) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fa3Yt-0004mJ-8z for guix-devel@gnu.org; Mon, 02 Jul 2018 14:28:31 -0400 In-Reply-To: <8736x1r1g0.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mark H Weaver writes: > Hi Marius, > > mbakke@fastmail.com (Marius Bakke) writes: > >> mbakke pushed a commit to branch staging >> in repository guix. >> >> commit cb4b508cd68df89bfbd5255a0c5569f8318ad50f >> Author: Marius Bakke >> Date: Mon Jul 2 12:07:58 2018 +0200 >> >> build-system/meson: Really skip the 'fix-runpath' phase on armhf. >>=20=20=20=20=20 >> This follows up commit d5b5a15a4046362377f1a45d466b43bb6e93d4f which= doesn't >> work because %current-system etc expands before the actual build. > > I'm disappointed by this workaround that simply removes the > 'fix-runpath' phase on armhf. Is that phase needed, or is it truly > optional? What does the phase accomplish, and how will armhf users be > disadvantaged by the removal of that phase? I'm sorry, I forgot to address your actual concerns. The (buggy) workaround was put in place and discussed in . The meat of it can be found in (guix build-system meson): ;; XXX PatchELF fails to build on armhf, so we skip ;; the 'fix-runpath' phase there for now. It is used ;; to avoid superfluous entries in RUNPATH as described ;; in , so armhf may now ;; have different runtime dependencies from other arches. Now, I'm not proud of this "workaround", but it's not exactly new, so I don't see why we should rush to fix it now. Given how late we are in this staging cycle, I would prefer delaying any proper fix until the next round. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAls6bswACgkQoqBt8qM6 VPodyAf/Z8XK7zKOPIKtDi4TxMyq38Jqh8DOGGrmZaPEURufB/Wht5yrYQMKcmDR G4XGBSss4dx5nwKy9Kec7FzIfcy7zASY3KrLk3ect1au7X0ZR/2u4vJxyhoyDhec z4Kh6DwhsaxtB+Qe+KpclXouZwLvdjgNmEdtapiBftoSF56JmoUfVEMchDlnPbi5 qYJeKe/5VR5bNhNRo3yE0ndZVxOPE9e5uqhobM0u3GaAU8A+3bqneaT2cW/jktH2 5Nk4IjBkEXnRP+Tglpc1erCmtAuVhIs407DZpHoE4mVcx4SY+MFtTg8ybqMg1QAF tETPPgrIZD/+ZLLVCBPpXdt8Z3s/MA== =u6tP -----END PGP SIGNATURE----- --=-=-=--