From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org, Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: 02/02: services: docker: Depend on elogind.
Date: Thu, 10 Jan 2019 09:59:02 +0100 [thread overview]
Message-ID: <874lagevmx.fsf@gnu.org> (raw)
In-Reply-To: <20190110041549.3E254204E8@vcs0.savannah.gnu.org> (guix-commits's message of "Wed, 9 Jan 2019 23:15:49 -0500 (EST)")
guix-commits@gnu.org skribis:
> commit f946a370edbf65baab41e8373e25157da5029a88
> Author: Danny Milosavljevic <dannym@scratchpost.org>
> Date: Thu Jan 10 05:14:43 2019 +0100
>
> services: docker: Depend on elogind.
>
> * gnu/services/docker.scm (docker-shepherd-service)[requirement]: Add elogind.
> ---
> gnu/services/docker.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/docker.scm b/gnu/services/docker.scm
> index c88fc34..9e24bcd 100644
> --- a/gnu/services/docker.scm
> +++ b/gnu/services/docker.scm
> @@ -70,7 +70,8 @@
> (shepherd-service
> (documentation "Docker daemon.")
> (provision '(dockerd))
> - (requirement '(containerd))
> + ;; Note: elogind is required because it's mounting the cgroups.
> + (requirement '(containerd elogind))
Cgroup file systems are mounted by the corresponding file system
services:
--8<---------------cut here---------------start------------->8---
$ sudo herd status | grep cgroup
+ file-system-/sys/fs/cgroup
+ file-system-/sys/fs/cgroup/blkio
+ file-system-/sys/fs/cgroup/cpu
+ file-system-/sys/fs/cgroup/cpuacct
+ file-system-/sys/fs/cgroup/cpuset
+ file-system-/sys/fs/cgroup/devices
+ file-system-/sys/fs/cgroup/elogind
+ file-system-/sys/fs/cgroup/freezer
+ file-system-/sys/fs/cgroup/memory
+ file-system-/sys/fs/cgroup/perf_event
--8<---------------cut here---------------end--------------->8---
Should it depend on ‘file-system-/sys/fs/cgroup/elogind’, or maybe both
‘elogind’ and ‘file-system-/sys/fs/cgroup/elogind’? Depends on what it
expects from elogind I guess…
Ludo’.
next parent reply other threads:[~2019-01-10 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190110041548.28584.50889@vcs0.savannah.gnu.org>
[not found] ` <20190110041549.3E254204E8@vcs0.savannah.gnu.org>
2019-01-10 8:59 ` Ludovic Courtès [this message]
2019-01-10 12:58 ` 02/02: services: docker: Depend on elogind Danny Milosavljevic
2019-01-10 13:57 ` Danny Milosavljevic
2019-01-10 22:13 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lagevmx.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).