From mboxrd@z Thu Jan  1 00:00:00 1970
From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: [PATCH] download: Support 'https_proxy'.
Date: Mon, 13 May 2019 21:36:52 +0800
Message-ID: <874l5ycw7f.fsf@member.fsf.org>
References: <874l62s88b.fsf@member.fsf.org> <87o946u4sy.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:60100)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@member.fsf.org>) id 1hQBMX-0003pS-Vv
	for guix-devel@gnu.org; Mon, 13 May 2019 09:51:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@member.fsf.org>) id 1hQB8f-0000YO-1Q
	for guix-devel@gnu.org; Mon, 13 May 2019 09:37:10 -0400
In-Reply-To: <87o946u4sy.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Mon, 13 May 2019 10:39:09 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Hi!
>
> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:
>
>> Hello, this patch add 'https_proxy' to 'guix download' (and guix-daemon
>> if we update guix?):
>
> Neat!

Pushed, thank you for the review!

>
>> From 424da6e43ba9c928403e3fd9b42e75d0fe90fc23 Mon Sep 17 00:00:00 2001
>> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iyz=
song@member.fsf.org>
>> Date: Fri, 10 May 2019 21:27:40 +0800
>> Subject: [PATCH] download: Support 'https_proxy'.
>>
>> * guix/build/download.scm (setup-http-tunnel): New procedure.
>> (open-connection-for-uri): Honor the 'https_proxy' environment variable.
>
> [...]
>
>> +(define (setup-http-tunnel port uri)
>> +  "Establish a tunnel to the destination server of URI."
>
> Maybe =E2=80=9CEstablish over PORT an HTTP tunnel to the destination serv=
er of
> URI.=E2=80=9D?

Sure.

>
> Otherwise LGTM!
>
>> Some problems and questions:
>>=20
>> - It assumes =E2=80=98https_proxy=E2=80=99 is =E2=80=98http://PROXY-SERV=
ER:PORT=E2=80=99, if the scheme
>>   part is missing, it fail.
>
> That=E2=80=99s already the case with =E2=80=98http_proxy=E2=80=99.
>
> It seems that other tools can happily deal with the lack of a URI
> scheme, so perhaps in a subsequent patch we should add code to
> automatically add a URI scheme when it=E2=80=99s missing?

Yes, I think the URI scheme can be =E2=80=98http=E2=80=99, =E2=80=98https=
=E2=80=99 or =E2=80=98socks5=E2=80=99, etc. and
default to =E2=80=98http=E2=80=99.  We only have =E2=80=98http=E2=80=99 now=
, other are good exercise :)

>
>> - It fails some servers (eg: www.google.com) for me while curl works...
>
> For www.google.com it fails even without =E2=80=98https_proxy=E2=80=99, s=
o that=E2=80=99s OK.
> :-)
>
>> - I think this should go into guile=E2=80=99s =E2=80=98(web client)=E2=
=80=99 module?
>
> Yes!  Once we=E2=80=99ve committed it Guix, it=E2=80=99d be great if you =
could a similar
> patch to bug-guile@gnu.org.
>
> Thank you!
>
> Ludo=E2=80=99.

Okay, get it!